-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spaceship Selection UI And Mechanics #107
Conversation
Co-Authored-By: Alex Tan <77610715+AlexTan35@users.noreply.github.com>
Co-Authored-By: Alex Tan <77610715+AlexTan35@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very nice, works really well!
let join_msg = SelectSpaceship { | ||
spaceship: ship_type, | ||
}; | ||
if let Err(e) = connection_manager.send_message::<OrdReliableChannel, _>(&join_msg) { | ||
error!("Failed to send JoinLobby message: {:?}", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let join_msg = SelectSpaceship { | |
spaceship: ship_type, | |
}; | |
if let Err(e) = connection_manager.send_message::<OrdReliableChannel, _>(&join_msg) { | |
error!("Failed to send JoinLobby message: {:?}", e); | |
let select_msg = SelectSpaceship { | |
spaceship: ship_type, | |
}; | |
if let Err(e) = connection_manager.send_message::<OrdReliableChannel, _>(&select_msg) { | |
error!("Failed to send SelectSpaceship message: {:?}", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One important thing to note here is that you also need to make sure that you cleanup the sent message at the server on client disconnection.
For that, I will make a push to demonstrate that.
…election and improve entity cleanup
Resolves #108