-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update used classes based on type arguments #92
Conversation
Professor, This is the PR to fix a bug of Specimin. Currently, there is a bug where Specimin fails to consider unsolved types if those types only appear as type arguments. For example, Specimin will overlook unsolved types This is one of the bugs that I have figured out while trying to make Specimin work for AnalysisResult.java (but right now there are still more bugs to fix before that happen) |
src/main/java/org/checkerframework/specimin/TargetMethodFinderVisitor.java
Outdated
Show resolved
Hide resolved
Professor, I have updated the documentation. I've tried to keep it shorter than the explanation I wrote in this PR. Please take a look. Thank you. |
src/main/java/org/checkerframework/specimin/TargetMethodFinderVisitor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkerframework/specimin/TargetMethodFinderVisitor.java
Outdated
Show resolved
Hide resolved
Professor, I have updated the codes so that we don't have to call two methods together every time we update the list of used classes based on the type of a used element. I have decided to use "element" instead of "member", because in the beginning of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this design is much cleaner.
No description provided.