Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update used classes based on type arguments #92

Merged
merged 12 commits into from
Jan 31, 2024

Conversation

LoiNguyenCS
Copy link
Collaborator

No description provided.

@LoiNguyenCS
Copy link
Collaborator Author

Professor,

This is the PR to fix a bug of Specimin.

Currently, there is a bug where Specimin fails to consider unsolved types if those types only appear as type arguments. For example, Specimin will overlook unsolved types BigTree and SmallTree in Map<BigTree, SmallTree>.

This is one of the bugs that I have figured out while trying to make Specimin work for AnalysisResult.java (but right now there are still more bugs to fix before that happen)

@LoiNguyenCS LoiNguyenCS requested a review from kelloggm January 27, 2024 21:36
@LoiNguyenCS
Copy link
Collaborator Author

Professor,

I have updated the documentation. I've tried to keep it shorter than the explanation I wrote in this PR. Please take a look. Thank you.

@LoiNguyenCS LoiNguyenCS requested a review from kelloggm January 30, 2024 00:27
@LoiNguyenCS
Copy link
Collaborator Author

Professor,

I have updated the codes so that we don't have to call two methods together every time we update the list of used classes based on the type of a used element. I have decided to use "element" instead of "member", because in the beginning of TargetMethodFinderVisitor, a member is defined to be a method or a field only.

@LoiNguyenCS LoiNguyenCS requested a review from kelloggm January 30, 2024 23:41
Copy link
Collaborator

@kelloggm kelloggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this design is much cleaner.

@kelloggm kelloggm merged commit c60cc85 into njit-jerse:main Jan 31, 2024
1 check passed
@kelloggm kelloggm deleted the update-type-vars branch January 31, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants