Feature/dlw components too

[whaeck]

Added components from the DLW block:

• outgoing energy distributions (ACE LAW=4)
• Kalbach-Mann systematics (ACE LAW=44)

As usual, some stuff comes first ;-)

[cjosey]

Alright. So, there are a few notes here.

Terms marked [clang-tidy] mean that that tool told me about these. If they were low priority, I noted the first time they came up only so that you can tell me if you want to persist in future reviews with these checks. The recommended ones I noted down every time they came up.

There were two concerning places. First, there was using the cosines in the Python to set the energy values. The second was using an array after it had been moved. Addressing those (or telling me I'm wrong) are what block approval.

The rest is suggestions and entirely up to you.

[cjosey]

[clang-tidy - low priority]
Suggest sorting includes alphabetically.

(I note this is consistent with most other implementations - will only mention here)

[cjosey]

[clang-tidy - recommended]
Add /* unused */ or equivalent for unused arguments.

(I note this is consistent with most other implementations - will only mention here)

[whaeck]

but later

[whaeck]

@cjosey fix/review-1 has been pushed and contains the changes mentioned above. In addition, I checked every generateXSS function for all blocks and made const/const auto/static_cast changes as required. Seems my code is just plain sloppy :-)

[cjosey]

All components have been adequately addressed in discussions. Here is the final .clang-tidy from this PR:

# Rationale for specific removals:
# Specific project removals:
#   We are not those projects, and these checks often have requirements
#   we do not care about.
# -llvm-header-guard
#   I like this, but the check seems to get confused by CMake and
#   tries to do the path all the way to root. I've yet to figure out why.
# -modernize-use-trailing-return-type
#   I've never seen a solid argument for the "full auto" format. It feels
#   like verbosity for the sake of verbosity
# -llvm-include-order
#   Does not match coding style
# -modernize-concat-nested-namespaces
#   Does not match coding style
# The following are of interest, but will not be added now.
# Namespace/namespace comments
# -readability-named-parameter
# -modernize-use-nodiscard
Checks: '*,-llvmlibc-*,-altera-*,-fuchsia-*,-hicpp-*,-llvm-namespace-comment,-google-readability-namespace-comments,-llvm-header-guard,-modernize-use-trailing-return-type,-llvm-include-order,-readability-named-parameter,-modernize-use-nodiscard,-modernize-concat-nested-namespaces'
# Need to use a complicated match as src/ matches [dependency]-src/
# and folders in Hana.
HeaderFilterRegex: 'src/ACEtk|src/utilities'

When we get near the end of this project, we can do a final pass with this. Future reviews will be done with this configuration.