Skip to content

Commit

Permalink
Changes following review.
Browse files Browse the repository at this point in the history
  • Loading branch information
whaeck committed Oct 7, 2024
1 parent bf7b3b5 commit 5daa0ac
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion python/src/depletion.python.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ void wrapDepletion( python::module& module, python::module& viewmodule ) {
python::module submodule = module.def_submodule(

"depletion",
"Depeltion NDI records and subrecords"
"Depletion NDI records and subrecords"
);

depletion::wrapReactionMultiplicityType( submodule, viewmodule );
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ def verify_chunk_typed( self, chunk ) :

# verify the record
self.assertEqual( 'rprod_all', chunk.keyword )
self.assertEqual( ReactionMultiplicityType.All, chunk.type )
self.assertEqual( False, chunk.empty )
self.assertEqual( 12, chunk.size )

Expand Down
2 changes: 1 addition & 1 deletion src/NDItk/depletion/Multiplicities/src/verify.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* @brief Verify the cross section data values
*
* The following verification tests are performed:
* - there are at least three values
* - there are at least two values
* - the reaction identifier looks to be an integer
*
* @param[in] data the data values in the cross section subrecord
Expand Down
2 changes: 1 addition & 1 deletion src/NDItk/depletion/ReactionMultiplicities/src/ctor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ ReactionMultiplicities( ReactionMultiplicityType type,
ReactionMultiplicities() : IntegerListRecord( base::Keyword( "rprod" ) ) {}

/**
* @brief Default constructor
* @brief Constructor for a multiplicity type
*/
ReactionMultiplicities( ReactionMultiplicityType type ) :
IntegerListRecord( base::Keyword( "rprod", type ) ) {}
Expand Down
2 changes: 2 additions & 0 deletions src/NDItk/depletion/ReactionMultiplicities/src/read.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
std::vector< int > data;
while ( reactions-- ) {

// read MT number and number of reaction products
data.push_back( njoy::tools::disco::FreeFormatInteger::read< int >( iter, end ) );
data.push_back( njoy::tools::disco::FreeFormatInteger::read< int >( iter, end ) );
int number = data.back();
Expand All @@ -24,6 +25,7 @@
}
else {

// read 2 numbers for each reaction product
number *= 2;
while ( number-- ) {

Expand Down
1 change: 0 additions & 1 deletion src/NDItk/depletion/ReactionMultiplicities/src/verify.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
*
* The following verification tests are performed:
* - there is at least one reaction
* - the number of groups for each reaction is the same
*
* @param[in] reactions the reactions to be verified
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ void verifyChunk( const ReactionMultiplicities& chunk ) {
CHECK( 2 == chunk.reactions()[1].multiplicities()[0] );
CHECK( 1 == chunk.reactions()[1].multiplicities()[1] );

auto multiplicities = chunk.reaction( 2 );
CHECK( 2 == chunk.reaction( 2 ).identifier() );
CHECK( 2 == chunk.reaction( 2 ).numberReactionProducts() );
CHECK( 1 == chunk.reaction( 2 ).reactionProducts()[0] );
Expand Down

0 comments on commit 5daa0ac

Please sign in to comment.