Feature/initial python #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
| "The reaction cross section record" | ||
| ); | ||
|
|
||
| // add standard table definitions |
There was a problem hiding this comment.
addStandardTableDefinitions doesn't seem to encapsulate everythin in NDItk/src/NDItk/MutigroupTable.hpp::MultigroupTable. The included read.hpp and the print don't seem to be part of this. They would need to be to be a full wrapper, yes?
There was a problem hiding this comment.
We only expose fromFile on full data tables, and I haven't added a toFile just yet to write one to a file. The read and print functions will not be exposed directly since these use iterators (and I also believe users shouldn't use these anyway).
tgsaller
reviewed
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the python bindings for the current state of NDItk.