Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kbk #319

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Feature/kbk #319

merged 8 commits into from
Oct 31, 2023

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Oct 26, 2023

This PR adds the different rmatrix background options to the samm.f90 coding. The background data is stored in a new array and the rmatrix is modified when required (subroutine setr). All three options (arbitrary tabulated complex function, Sammy and Frohner parametrisation) are supported.

This change is made in anticipation of a new Sr88 evaluation that will make it into ENDF/B-VIII.1 that uses the background rmatrix option (the Sammy parametrisation in particular). The test results have not been compared to Sammy data (I'm waiting on ORNL feedback) but that does not have to stop us to start the review process.

Little caveat: the use of these background options requires updates to the partial derivatives - which are used by ERRORR when MF32 covariances are used. I updated dead code that seemed to add these derivatives for the Sammy parametrisation but none of the other options have any logic in the code to calculate these derivatives. Since the original code was never used, I'm also not sure of the results. Luckily for us, the Sr88 evaluation currently does not have covariance data associated to them.

I also updated the code to add a number of error messages:

  • the LRF=7 code only works with KRM=3, any other value triggers a call to error
  • IFG != 0 is now flagged as an error (the coding assumes full widths)
  • background rmatrix elements are only allowed for KRM=3, as per ENDF rules

For more information on these options: https://www.nndc.bnl.gov/endf/format/endf-manual-latest.pdf

@whaeck
Copy link
Member Author

whaeck commented Oct 30, 2023

Comparisons with Sammy have shown that the calculated cross sections are correct within ENDF precision (there is only one channel in the test file: elastic):
Figure 3
Figure 6
Figure 8

@whaeck
Copy link
Member Author

whaeck commented Oct 30, 2023

There was another correction in the sammy data, so the capture ratio is like this now:
Figure 6(1)

Also seems to be within ENDF precision so we're good on all fronts.

Copy link
Contributor

@kahlerac kahlerac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work!

@whaeck whaeck merged commit 3354993 into develop Oct 31, 2023
8 checks passed
@whaeck whaeck deleted the feature/kbk branch October 31, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants