Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/leapr array #320

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Fix/leapr array #320

merged 8 commits into from
Oct 30, 2023

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Oct 26, 2023

@HunterBelanger Everything looks good now. Tests pass so we're good to go. The failing tests must have been fixed in the last update you made.

@whaeck whaeck requested a review from kahlerac October 26, 2023 17:50
Copy link
Contributor

@kahlerac kahlerac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising to not see any deallocation statements in subroutine contin. contin is called from within a loop over user specified temperature. Do existing tests include a multiple temperature leapr job to assure we don't get an already allocated runtime error?

@HunterBelanger
Copy link
Contributor

Test 23 should have multiple temperatures in the LEAPR input. I believe that since Fortran 95, allocatable arrays are automatically deallocated when they go out of scope. I think this is why there are no deallocation statements at the end of contin. I didn't see any for the other arrays like p, tlast, tnow, and xa, so I didn't add one for maxt.

@whaeck
Copy link
Member Author

whaeck commented Oct 30, 2023

Deallocation will be required when you run LEAPR multiple times in the same input deck. This is an issue we have seen in the past with other modules like ERRORR. In this case, I don't think it is necessary to protect users against themselves.

As such, I'll pull this into develop. If the deallocation comes up later, we'll just fix it then.

@whaeck whaeck merged commit 11dbf95 into develop Oct 30, 2023
8 checks passed
@whaeck whaeck deleted the fix/leapr_array branch October 30, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants