Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/urr background #342

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Fix/urr background #342

merged 5 commits into from
Aug 12, 2024

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Jul 23, 2024

Background cross section values for reactions other than total, elastic, fission and capture were not handled properly in the unresolved resonance region. The background for total, elastic, fission and capture is integrated into the unresolved resonance cross section values in the genunr subroutine. In the emerge subroutine, the background in the unresolved resonance region was therefore zeroed out for any resonance reaction. This has never been an issue but now we have LRF=7 evaluations that can define reactions other than total, elastic, fission and capture. Test 82 was added to detect this issue in the future.

@kahlerac
Copy link
Contributor

kahlerac commented Jul 23, 2024 via email

@whaeck
Copy link
Member Author

whaeck commented Jul 23, 2024

We have time. The Mo95 evaluation that illustrates the issue is not in ENDF/B-VIII.1 and I don;t expect it to be adopted in time for the ENDF/B-VIII.1 release. If we can get this done by the end of September, I'm OK with it.

The missing xs values were of the order of microbarn so not that important either. However, I do not know how much this new evaluation would change the capture cross section with respect to the current ENDF/B-VIII.1b4 version.

Copy link
Contributor

@kahlerac kahlerac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With hindsight it's a simple fix, but something subtle that was easy to overlook during lrf=7 implementation ... good work!

@whaeck
Copy link
Member Author

whaeck commented Aug 12, 2024

Lucky for us indeed :-)

Red pointed this issue out to me a few weeks ago. Took me a while to dig through the code to fix it, but it was an easy one.

@whaeck whaeck merged commit 0b9da73 into develop Aug 12, 2024
8 checks passed
@whaeck whaeck deleted the fix/urr-background branch August 12, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants