Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing array size #343

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Increasing array size #343

merged 4 commits into from
Aug 12, 2024

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Aug 1, 2024 •
edited
Loading

Just a simple fix: increasing the size of internal arrays to ensure that VIEWR runs to completion.

kahlerac
kahlerac approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@kahlerac kahlerac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but maybe next time (there's always a next time!) make the 2000 a parameter variable and add a test after line 1324 (j=j+1) to avoid a possible array overflow.

kahlerac
kahlerac previously approved these changes Aug 12, 2024
View reviewed changes
Base automatically changed from fix/urr-background to develop August 12, 2024 14:14
@whaeck whaeck dismissed kahlerac’s stale review August 12, 2024 14:14

The base branch was changed.

@whaeck
Copy link
Member Author

whaeck commented Aug 12, 2024

@kahlerac That's indeed better, I made the change you suggested. You'll have to reapprove though.

@whaeck whaeck merged commit dff41e9 into develop Aug 12, 2024
8 checks passed
@whaeck whaeck deleted the fix/viewr-array branch August 12, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahlerac kahlerac kahlerac approved these changes

@nathangibson14 nathangibson14 Awaiting requested review from nathangibson14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whaeck @kahlerac