In-memory changes not being pushed #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be used for developing CSS Editing unit tests.
just a couple of small changes.
In-memory changes are now being pushed when launching a new session of LiveDevelopment. Remove inconsistencies on method names between livedev implementations.
Collaborator
|
I'm getting errors in new unit tests on Win7 with Firefox as default browser: should push changes through browser connection TypeError: Cannot call method 'replace' of undefined
at fixSpaces (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/src/extensions/dev/brackets-livedev2/unittests.js:53:24)
at null.<anonymous> (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/src/extensions/dev/brackets-livedev2/unittests.js:268:28)
at jasmine.Block.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1064:17)
at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2096:31)
at onComplete (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2092:18)
at jasmine.WaitsForBlock.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2576:5)
at file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2590:12should push in memory css changes made before the session starts TypeError: Cannot call method 'replace' of undefined
at fixSpaces (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/src/extensions/dev/brackets-livedev2/unittests.js:53:24)
at null.<anonymous> (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/src/extensions/dev/brackets-livedev2/unittests.js:312:28)
at jasmine.Block.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1064:17)
at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2096:31)
at onComplete (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2092:18)
at jasmine.WaitsForBlock.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2576:5)
at file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2590:12
|
Collaborator
|
I verified that tests pass on MacOSX 10.8/Safari. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-memory changes were not being pushed when launching a new session of LiveDevelopment.
Inconsistencies between method
CSSDocument._updateBrowseron current implementation andLiveCSSDocument.updateBrowseron this new implementation prevented it to be invoked atBaseServer._setDocInfo.A new test for it is included. This PR is on top of #26.