Open
Conversation
307587
changed the title
syimyuzya
reviewed
Dec 9, 2024
Co-authored-by: Sêkai Zhou <syimyuzya@gmail.com>
Co-authored-by: graphemecluster <graphemecluster@gmail.com>
Co-authored-by: graphemecluster <graphemecluster@gmail.com>
Co-authored-by: Sêkai Zhou <syimyuzya@gmail.com>
Co-authored-by: graphemecluster <graphemecluster@gmail.com>
Co-authored-by: graphemecluster <graphemecluster@gmail.com>
Author
|
應該可以了 |
Author
|
為什麼還未合併？是不是還有什麼問題？ |
Member
啊不好意思😂 一直沒發現已經做完了 |
syimyuzya
requested changes
Dec 23, 2025
Member
syimyuzya
left a comment
syimyuzya
left a comment
There was a problem hiding this comment.
討論了一下，這個結構的推導方案模板，還是不太適合效法。
參考最近我們寫的較新的推導方案（例如新版 unt 擬音、平水韻（盛唐）擬音，以及稍早些的《中原音韻》擬音等等），再提一些需要調整的地方：
聲母規則等名字不適合用作函數名，作get聲母這樣的動詞成分為佳- 推聲母、韻母、聲調三者，然後作調整，這種邏輯說不上好用。可以像上述參考的方案那樣，定義
get音節，然後在裡面依照具體需要，去定義音節成分或屬性，比如聲母、介音、韻基（或核/尾）、聲調等（在模板中可以不用都給出來，給個get聲母的框架然後用註解提示還可以寫些什麼就好）- 另外，作為推導結果的各成分，均置於一
音節物件中，也令其名稱在代碼中更清晰 - 上述參考中，中原音韻方案稍早些，沒完全像這樣做，也用的
get韻母，但它裡面也是有內部結構的
- 另外，作為推導結果的各成分，均置於一
- 入聲韻尾自然也不適合作為「後期處理」，推導韻尾時就可以直接做
- 相應地，推導結果中的
韻母 + 聲調也並不好用，在這之前先處理出「帶調的韻基」結果更合適 - 羅列「攝」的註解可以直接不要（就像聲母那樣給一個例子就好，比如就給一個
// ['止攝', '止攝韻基']之類）
以上作為參考建議，如果還有什麼經驗（或想法）也歡迎提出或嘗試～
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes nk2028/tshet-uinh-examples#58