Populated the value of piece_bb[NO_PIECE]#14
Open
osvitashev wants to merge 1 commit intonkarve:masterfrom
Open
Populated the value of piece_bb[NO_PIECE]#14osvitashev wants to merge 1 commit intonkarve:masterfrom
osvitashev wants to merge 1 commit intonkarve:masterfrom
Conversation
It is initialized to all '1's in default Position constructor; The value is updated in put_piece, remove_piece, move_piece and move_piece_quiet methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea was to make piece_bb[NO_PIECE] usable. It is not required for move generation, as it can always be derived form other bit boards. However, I have found not having this value readily accessible to be unintuitive.
It is initialized to all '1's in default Position constructor;
The value is updated in put_piece, remove_piece, move_piece and move_piece_quiet methods
Updated generate_legals and ran perft to validate correct behavior.
Hopefully i have not missed anything