feat(icon): huge icon component and icon set overhaul and refactoring #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ruben-Smit
force-pushed
the
feature/register-icon-sets
branch
from
43ca920 to
78bc032
Compare
Ruben-Smit
changed the base branch from
feature/improve-action-group-and-accordion
to
main
added 2 commits
January 17, 2025 10:32
…custom icon sets and added and improved documentation
…using Object.keys
Ruben-Smit
force-pushed
the
feature/register-icon-sets
branch
from
78bc032 to
b9ca8fd
Compare
Ruben-Smit
changed the title
veslav3
reviewed
Jan 18, 2025
packages/storybook/src/icon-sets/default-icon-set-page/index.css
Outdated
Show resolved
Hide resolved
|
Algemene review comment, bij storybook zie ik bij flag icon sets een mooie sample code, maar bij de default icon set niet: https://rijkshuisstijl-community-git-feature-re-4f8d25-nl-design-system.vercel.app/?path=/docs/rhc-templates-default-icon-set--docs |
@veslav3 het gebruik van de default icon set werkt exact hetzelfde als Icon, er staat daarom een referentie naar de storybook pagina van de Icon component in de docs van de default icon set |
Ruben-Smit
force-pushed
the
feature/register-icon-sets
branch
from
600f415 to
3d87fa3
Compare
veslav3
reviewed
Jan 22, 2025
veslav3
reviewed
Jan 22, 2025
veslav3
reviewed
Jan 22, 2025
|
veslav3
approved these changes
Jan 22, 2025
WebBeest
pushed a commit
that referenced
this pull request
Jan 27, 2025
…#1136) closes #764 closes #446 - Refactored Icon component - Created icon-set directory with icons - Refactored default icon set - Renamed default icon ID type to RHCIconID - Added [icon documentation](https://rijkshuisstijl-community-git-feature-re-4f8d25-nl-design-system.vercel.app/?path=/docs/rhc-icon--docs) - Added unit tests - Added flag icon set - Added [default icon set storybook page](https://rijkshuisstijl-community-git-feature-re-4f8d25-nl-design-system.vercel.app/?path=/docs/rhc-templates-default-icon-set--docs) - Added [flag icon set storybook page](https://rijkshuisstijl-community-git-feature-re-4f8d25-nl-design-system.vercel.app/?path=/docs/rhc-templates-flag-icon-set--docs) --------- Co-authored-by: Ruben Smit <rsmit@quintor.local>
WebBeest
pushed a commit
that referenced
this pull request
Jan 27, 2025
…#1136) closes #764 closes #446 - Refactored Icon component - Created icon-set directory with icons - Refactored default icon set - Renamed default icon ID type to RHCIconID - Added [icon documentation](https://rijkshuisstijl-community-git-feature-re-4f8d25-nl-design-system.vercel.app/?path=/docs/rhc-icon--docs) - Added unit tests - Added flag icon set - Added [default icon set storybook page](https://rijkshuisstijl-community-git-feature-re-4f8d25-nl-design-system.vercel.app/?path=/docs/rhc-templates-default-icon-set--docs) - Added [flag icon set storybook page](https://rijkshuisstijl-community-git-feature-re-4f8d25-nl-design-system.vercel.app/?path=/docs/rhc-templates-flag-icon-set--docs) --------- Co-authored-by: Ruben Smit <rsmit@quintor.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #764
closes #446