Skip to content

fix: reduce churn #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: reduce churn #236

merged 1 commit into from
Jan 24, 2025

Conversation

matijs
Copy link
Member

@matijs matijs commented Jan 24, 2025

Prevent unnecessary "changes" by adding the "source" block that GitHub keeps around invisibly in the background.

See this example from an API call to the pages endpoint of the candidate repository. "source" is still present even though "build_type" is set to "workflow".

{
  "url":
    "https://api.github.com/repos/nl-design-system/candidate/pages",
    "status": null,
    "cname": null,
    "custom_404": false,
    "html_url": "https://nl-design-system.github.io/candidate/",
    "build_type": "workflow",
    "source": {
      "branch": "main",
      "path": "/"
    },
    "public": true,
    "protected_domain_state": null,
    "pending_domain_unverified_at": null,
    "https_enforced": true
}

@matijs matijs requested a review from Robbert January 24, 2025 10:34
@matijs matijs requested a review from a team as a code owner January 24, 2025 10:34
@matijs matijs enabled auto-merge (rebase) January 24, 2025 10:45
@matijs matijs disabled auto-merge January 24, 2025 11:13
@matijs matijs marked this pull request as draft January 24, 2025 11:13
@matijs matijs force-pushed the fix/candidate-pages-branch branch from 320771c to 39eddfe Compare January 24, 2025 11:36
Prevent unnecessary "changes" by adding the "source" block that GitHub
keeps around invisibly in the background.

See this example from an API call to the pages endpoint of the candidate
repository. `"source"` is still present even though `"build_type"` is
set to `"workflow"`.

```json
{
  "url":
    "https://api.github.com/repos/nl-design-system/candidate/pages",
    "status": null,
    "cname": null,
    "custom_404": false,
    "html_url": "https://nl-design-system.github.io/candidate/",
    "build_type": "workflow",
    "source": {
      "branch": "main",
      "path": "/"
    },
    "public": true,
    "protected_domain_state": null,
    "pending_domain_unverified_at": null,
    "https_enforced": true
}
```
@matijs matijs force-pushed the fix/candidate-pages-branch branch from 39eddfe to b07473c Compare January 24, 2025 11:37
Copy link

@matijs matijs marked this pull request as ready for review January 24, 2025 11:37
@matijs matijs enabled auto-merge (rebase) January 24, 2025 12:35
Copy link
Member

@Robbert Robbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slim!

@matijs matijs merged commit 977088d into main Jan 24, 2025
3 checks passed
@matijs matijs deleted the fix/candidate-pages-branch branch January 24, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants