refactor: define FormFieldCheckbox properties in a way where optional…

… fields are more resiliently defined
nl-design-system · Nov 24, 2024 · 2ceb531 · 2ceb531
1 parent a01401a
commit 2ceb531
Showing 1 changed file with 15 additions and 18 deletions.
diff --git a/packages/components-react/form-field-checkbox-react/src/index.tsx b/packages/components-react/form-field-checkbox-react/src/index.tsx
@@ -10,29 +10,26 @@ import type { ForwardedRef, PropsWithChildren, ReactNode, Ref } from 'react';
 import { forwardRef, useId } from 'react';
 
 export interface FormFieldCheckboxProps
-  extends Omit<FormFieldProps, 'onBlur' | 'onChange' | 'onFocus' | 'onInput' | 'type'>,
-    Pick<
-      CheckboxProps,
-      | 'checked'
-      | 'defaultChecked'
-      | 'defaultValue'
-      | 'disabled'
-      | 'indeterminate'
-      | 'inputRequired'
-      | 'invalid'
-      | 'name'
-      | 'onBlur'
-      | 'onChange'
-      | 'onFocus'
-      | 'onInput'
-      | 'required'
-      | 'value'
-    > {
+  extends Omit<FormFieldProps, 'onBlur' | 'onChange' | 'onFocus' | 'onInput' | 'type'> {
+  checked?: CheckboxProps['checked'];
+  defaultChecked?: CheckboxProps['defaultChecked'];
+  defaultValue?: CheckboxProps['defaultValue'];
   description?: ReactNode;
+  disabled?: CheckboxProps['disabled'];
   errorMessage?: ReactNode;
+  indeterminate?: CheckboxProps['indeterminate'];
   inputRef?: Ref<HTMLInputElement>;
+  inputRequired?: CheckboxProps['inputRequired'];
+  invalid?: CheckboxProps['invalid'];
   label: ReactNode;
+  name?: CheckboxProps['name'];
+  onBlur?: CheckboxProps['onBlur'];
+  onChange?: CheckboxProps['onChange'];
+  onFocus?: CheckboxProps['onFocus'];
+  onInput?: CheckboxProps['onInput'];
+  required?: CheckboxProps['required'];
   status?: ReactNode;
+  value?: CheckboxProps['value'];
 }
 
 export const FormFieldCheckbox = forwardRef(