Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: actions slot for alert #1772

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: actions slot for alert #1772

wants to merge 2 commits into from

Conversation

Robbert
Copy link
Member

@Robbert Robbert commented Jun 22, 2023

No description provided.

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utrecht ❌ Failed (Inspect) Dec 24, 2024 10:28am

@Robbert
Copy link
Member Author

Robbert commented Jul 24, 2023

The grid layout causes the gap to show up between the icon area and the message area, as well as between the message area and the action_ area. The alert now has too much white space. Should fix this before merging.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.15%. Comparing base (1c16253) to head (d08e09c).

Files with missing lines Patch % Lines
packages/component-library-react/src/Alert.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
- Coverage   90.20%   90.15%   -0.06%     
==========================================
  Files         188      188              
  Lines        1644     1645       +1     
  Branches      351      352       +1     
==========================================
  Hits         1483     1483              
+ Misses        157      156       -1     
- Partials        4        6       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant