generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 23
feat(react): create ScrollLink component #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5077239
to
0e7b3fe
Compare
"start" instead of "top" is in line with our logical properties approach
0e7b3fe
to
703d145
Compare
Feature request from Jeffrey: https://tholman.com/elevator.js/ |
703d145
to
31e5361
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
- Coverage 93.98% 91.37% -2.61%
==========================================
Files 157 190 +33
Lines 1313 1577 +264
Branches 287 313 +26
==========================================
+ Hits 1234 1441 +207
- Misses 78 135 +57
Partials 1 1 ☔ View full report in Codecov by Sentry. |
e16bf2d
to
9e321e8
Compare
b1e71fa
to
7ca895a
Compare
ik snap er helemaal niks van! waarom faalt de build op |
c8ed0a6
to
37c4394
Compare
37c4394
to
e3d535f
Compare
Robbert
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.