Skip to content

feat(react): create ScrollLink component #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 2, 2024
Merged

Conversation

AliKdhim87
Copy link
Contributor

No description provided.

@AliKdhim87 AliKdhim87 changed the title Create scroll to top button feat(css): create ScrollToTopButton CSS component Nov 8, 2023
@AliKdhim87 AliKdhim87 requested a review from Robbert November 8, 2023 12:55
@AliKdhim87 AliKdhim87 force-pushed the create-scroll-to-top-button branch from 5077239 to 0e7b3fe Compare November 13, 2023 11:57
@AliKdhim87 AliKdhim87 changed the title feat(css): create ScrollToTopButton CSS component feat(react): create ScrollToTopButton component Nov 13, 2023
"start" instead of "top" is in line with our logical properties approach
@Robbert Robbert force-pushed the create-scroll-to-top-button branch from 0e7b3fe to 703d145 Compare February 14, 2024 08:07
@Robbert
Copy link
Member

Robbert commented Oct 8, 2024

Feature request from Jeffrey: https://tholman.com/elevator.js/

@Robbert Robbert force-pushed the create-scroll-to-top-button branch from 703d145 to 31e5361 Compare October 21, 2024 14:12
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.37%. Comparing base (2e398a8) to head (37c4394).

Files with missing lines Patch % Lines
...ackages/component-library-react/src/ScrollLink.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
- Coverage   93.98%   91.37%   -2.61%     
==========================================
  Files         157      190      +33     
  Lines        1313     1577     +264     
  Branches      287      313      +26     
==========================================
+ Hits         1234     1441     +207     
- Misses         78      135      +57     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbert Robbert force-pushed the create-scroll-to-top-button branch from e16bf2d to 9e321e8 Compare October 21, 2024 16:08
@Robbert Robbert force-pushed the create-scroll-to-top-button branch 2 times, most recently from b1e71fa to 7ca895a Compare October 21, 2024 16:34
@Robbert Robbert changed the title feat(react): create ScrollToTopButton component feat(react): create ScrollLink component Oct 22, 2024
@Robbert
Copy link
Member

Robbert commented Oct 22, 2024

ik snap er helemaal niks van! waarom faalt de build op badge?

@AliKdhim87 AliKdhim87 force-pushed the create-scroll-to-top-button branch from c8ed0a6 to 37c4394 Compare October 22, 2024 08:56
@Robbert Robbert force-pushed the create-scroll-to-top-button branch from 37c4394 to e3d535f Compare November 2, 2024 09:56
@Robbert Robbert enabled auto-merge (squash) November 2, 2024 10:01
@Robbert Robbert disabled auto-merge November 2, 2024 12:06
@Robbert Robbert merged commit 5d83fc4 into main Nov 2, 2024
10 of 14 checks passed
@Robbert Robbert deleted the create-scroll-to-top-button branch November 2, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants