-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove background image from custom checkbox focus styles #2675
fix: remove background image from custom checkbox focus styles #2675
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
=======================================
Coverage 90.20% 90.20%
=======================================
Files 188 188
Lines 1644 1644
Branches 352 351 -1
=======================================
Hits 1483 1483
- Misses 155 157 +2
+ Partials 6 4 -2 ☔ View full report in Codecov by Sentry. |
@MeesoPost Waarom fixt dit iets? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Could you also make sure the background image is not set on other states like :active
?
Also this PR needs a changeset to create a new release :)
Het voorkomt dat de checked image al inlaad zodat als je erop focused en de background color veranderd naar een donkere kleur dat de checkmark verschijnt zoals in purmerend