Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove background image from custom checkbox focus styles #2675

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

MeesoPost
Copy link
Contributor

@MeesoPost MeesoPost commented Dec 23, 2024

Het voorkomt dat de checked image al inlaad zodat als je erop focused en de background color veranderd naar een donkere kleur dat de checkmark verschijnt zoals in purmerend
image

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utrecht ❌ Failed (Inspect) Dec 24, 2024 1:35am

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (c5d4232) to head (50cccbc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2675   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files         188      188           
  Lines        1644     1644           
  Branches      352      351    -1     
=======================================
  Hits         1483     1483           
- Misses        155      157    +2     
+ Partials        6        4    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MeesoPost MeesoPost marked this pull request as ready for review December 23, 2024 14:48
@Robbert
Copy link
Member

Robbert commented Dec 23, 2024

@MeesoPost Waarom fixt dit iets?

@MeesoPost MeesoPost requested a review from Yolijn December 23, 2024 14:51
@MeesoPost
Copy link
Contributor Author

Het voorkomt dat de checked image al inlaad zodat als je erop focused en de background color veranderd naar een donkere kleur dat de checkmark verschijnt zoals in purmerend
image

Copy link
Member

@Yolijn Yolijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Could you also make sure the background image is not set on other states like :active?

Also this PR needs a changeset to create a new release :)

@Robbert Robbert merged commit 0003a70 into main Dec 24, 2024
7 of 10 checks passed
@Robbert Robbert deleted the fix/-custom-checkbox-remove-background-image-when-focus branch December 24, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants