Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRICT_R_HEADERS #3

Merged
merged 2 commits into from
Aug 25, 2024
Merged

STRICT_R_HEADERS #3

merged 2 commits into from
Aug 25, 2024

Conversation

mattfidler
Copy link
Member

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_PreciseSums.html.

Specifically, please see the Strict additional issue.

Compilation fails with R_USE_STRICT_R_HEADERS=true, which defines
STRICT_R_HEADERS to 1 which removes

  • the legacy definition of PI (use POSIX's M_PI, available in R fer ever).
  • the RS.h declarations for Calloc, Realloc, Free (use R_ forms i
    available since R 3.4.0).

The aim is to clean the namespace: in particular having a definition
for Free has conflicted with some packages' C++ code.

It is planned that STRICT_R_HEADERS=1 will become the default for 4.5.0,
which in particular makes it necesssary that all CRAN packages with many
strong reverse dependencies compile/install ok with the new default.

Your package is among the ones with many strong reverse dependencies.
We would thus really appreciate if you could provide a new version of
your package as soon as possible which checks ok with
STRICT_R_HEADERS=1.

You can verify that your package checks ok with STRICT_R_HEADERS=1 via R
CMD check --as-cran using a current version of R-devel.

Please correct before 2024-09-20 to safely retain your package on CRAN.

@mattfidler mattfidler merged commit a23f045 into main Aug 25, 2024
4 checks passed
@mattfidler mattfidler deleted the 3-strict branch August 25, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant