Skip to content

Commit

Permalink
Update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
wibeasley committed Apr 17, 2016
1 parent 02ec3bf commit 2e63e9e
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 34 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: NlsyLinks
Type: Package
Title: Utilities and Kinship Information for Research with the NLSY
Version: 2.0.4.9001
Date: 2016-03-25
Version: 2.0.5
Date: 2016-04-17
Author: Will Beasley, Joe Rodgers, David Bard, Michael Hunter, S. Mason
Garrison, and Kelly Meredith
Maintainer: Will Beasley <wibeasley@hotmail.com>
Expand Down
43 changes: 11 additions & 32 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,45 +1,24 @@
## Description
This submission updates & improves various small things. Many changes are to keep up with CRAN policy changes since April 2014. For instance, a shorter title, and using `requireNamespace()` instead of `require()`. Please tell me if there's something else I should do for CRAN.
This submission corresponds to the new version of testthat. One of the tests catching a failing condition needed to change. -Will Beasley

After my first submission last night, Kurt caught that the URL in the description field wasn't enclosed in <...>; that is now corrected.
Test environments
-----------------------------------------------

> I get
>
```
Found the following (possibly) invalid URLs:
URL: http://www.bls.gov/nls/nlsy79ch.htm)
From: man/Links79Pair.Rd
Status: 404
Message: Not Found
```
> Can you pls fix? (Remove the final paren from the URL).
>
> In plain text (such as the Description field) it is recommended to enclode URLs in <...>
For some reason, that wasn't caught by the five remote test machines. I'm open to any suggestions how to configure these builds so they mimic CRAN machines and prevent more of my mistakes slipping through to a human. The five that I ran last night before my first submission were:

* [win-builder R-devel](http://win-builder.r-project.org/68aDSl8xhbGq/00check.log)
* [win-builder R-release](http://win-builder.r-project.org/WstV5xxuzI3F/00check.log)
* [Travis-CI `--as-cran`](https://travis-ci.org/LiveOak/NlsyLinks/builds/75873235#L1736)
* [AppVeyor `--as-cran`](https://ci.appveyor.com/project/wibeasley/nlsylinks/build/1.0.29#L218)
* [Werker](https://app.wercker.com/#buildstep/55d13044b006c1f91e048052)

-Will Beasley

## Test environments
* Local Win8, R 3.2.2 patched
* [win-builder (version="R-devel")](http://win-builder.r-project.org/GMzN79RmpJJU)
* Local Ubuntu 14.04 LTS
* [win-builder (version="R-devel")](http://win-builder.r-project.org/68aDSl8xhbGq)
* [Travis CI, Ubuntu 12.04 LTS](https://travis-ci.org/LiveOak/NlsyLinks/)
* [AppVeyor, Windows Server 2012](https://ci.appveyor.com/project/wibeasley/nlsylinks)
* [Werker, Docker](https://app.wercker.com/#applications/5590d20a4fea05eb7a02e590)
<!-- * [Werker, Docker](https://app.wercker.com/#applications/5590d20a4fea05eb7a02e590) -->

R CMD check results
-----------------------------------------------

## R CMD check results
* No ERRORs or WARNINGs on any builds.
* One NOTEs on win-builder.
* One notable NOTE:
1. The package size has a few large data files; the data size is around 4Mb. I believe the size is justified because it drastically reduces the code needed for the package user to start incorporating their outcomes on to the larger familial framework we've build. (One of the package's cornerstones is how we've linked the 24,000 participants within the 5,160 extended families.)
a. The (uncompressed) CSV is needed for an important example how to incorporate the CSVs downloaded from the NLSY database. I've used only the necessary columns.
b. The compressed RDA files have important participant data the allows the package user to incoporate
* No other unexplainable NOTEs on the other builds.
* No other unexplainable NOTEs. The AppVeyor bulid complains about the vingette, but I think that's something specific to that test environment, and not to the package.

## Downstream dependencies
No other packages depend/import this one.

0 comments on commit 2e63e9e

Please sign in to comment.