Only import tkinter if a GUI is needed #3348
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only import tkinter if the user is calling a function that explicitly uses a GUI instead of at the top-level.
This avoids the issue on macOS where calling fork after importing nltk without using any gui-related features causes the program to segfault.
Also adds the env var NLTK_DOWNLOADER_FORCE_INTERACTIVE_SHELL which forces the use of the interactive shell when using interactive downloader if set to 'true'.
Fixes #2949.
Tested that the reproducing program no longer crashes:
Tested that the nltk downloader GUI still works when explicitly requested.
Tested that the nltk.sem.drt draw demos still work.