Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified add_theme to color plots with nmfspalette #6

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

sbreitbart-NOAA
Copy link
Collaborator

In my testing, adding

  nmfspalette::scale_color_nmfs() +
  nmfspalette::scale_fill_nmfs() 

to the existing plot code worked out fine, regardless of whether the plot is a scatterplot, line plot, etc. But this may fail with other types of plots.

Copy link
Collaborator

@Schiano-NOAA Schiano-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now that the remote has been added. Please remove the extrafont package in the DECRIPTION in line 25 and then run devtools::document() in your console then commit those changes. Then go ahead with merging

@sbreitbart-NOAA sbreitbart-NOAA merged commit 4b7f072 into master Sep 26, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants