add generalized size composition test model #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iantaylor-NOAA
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Good to get this model added to the test set.
The warnings file indicates the gradient is a little high and poor convergence in F0.1 search. These shouldn't impact the utility of this model for testing, but we may want to tinker with the model at some point in the future to see if convergence can be improved. (as in #51).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #54 in this repo and issue #542 in ss3-source-code repo.
@Rick-Methot-NOAA please add any edits/suggestions to the model name and description.