Check if establishing relationship is possible #451
Conversation
…-establishing-relationship-is-possible
…-establishing-relationship-is-possible
…ng-relationship-is-possible' into check-if-establishing-relationship-is-possible
…-establishing-relationship-is-possible # Conflicts: # apps/enmeshed/lib/core/app_ui_bridge.dart # apps/enmeshed/lib/core/modals/error_dialog.dart
…-establishing-relationship-is-possible
| @@ -8,6 +8,7 @@ class DismissibleContactItem extends StatefulWidget { | |||
| final IdentityDVO contact; | |||
| final VoidCallback onTap; | |||
| final void Function(BuildContext) onDeletePressed; | |||
| final bool isRequestExpired; | |||
There was a problem hiding this comment.
you should pass the request instead of this boolean, for this widget the variable name and type is very meaningless
| if (!widget.validateCreateRelationship) return; | ||
|
|
||
| final session = GetIt.I.get<EnmeshedRuntime>().getSession(widget.accountId); |
There was a problem hiding this comment.
I think we discussed a very important part that was just ignored here. This function now runs every time a request is rendered that originates from a template. But I miss the check for the existing relationship.
Also, is this really the correct place to run this check? Can't we move this to the request screen?
There was a problem hiding this comment.
In RequestScreen i do "validateCreateRelationship: requestDVO?.source?.type == LocalRequestSourceType.RelationshipTemplate" and pass that to the param validateCreateRelationship, which returns on line 317
There was a problem hiding this comment.
But i guess i could do this whole check in RequestScreen
There was a problem hiding this comment.
Hm, as you see it's not a good idea to split this information
…ip-is-possible' into check-if-establishing-relationship-is-possible
| onDeletePressed: _onDeletePressed, | ||
| subtitle: |
There was a problem hiding this comment.
that subtitle should be set inside of the DismissibleContactItem (you already inject the request in there)
|
|
||
| if (!context.mounted) return; | ||
|
|
||
| if (result != null && result) await _onDeletePressed(context); |
There was a problem hiding this comment.
| if (result != null && result) await _onDeletePressed(context); | |
| if (result == true) await _onDeletePressed(context); |
There was a problem hiding this comment.
result can be null, but i use now if (result ?? false) instead
| @@ -147,3 +151,19 @@ Future<void> deleteContact({ | |||
|
|
|||
| onContactDeleted(); | |||
| } | |||
|
|
|||
| Future<({bool success, String? errorCode})> validateRelationshipCreation({ | |||
There was a problem hiding this comment.
again - this is not enough. type RelationshipTemplate only means that it originates from a RelationshipTemplate, but it could also originate from onExistingRelationship, then we wouldn't create a relationship and instead answer using a message.
Please talk to the runtime team how to handle this properly, I suggest @Milena-Czierlinski as a sparring partner. Maybe we can make the requestDVO event smarter so that we KNOW if it would be answered using a Relationship or a Message ;)
If you discussed this please tell me the results.
There was a problem hiding this comment.
We think it could be enough to check for localRequestDVO.peer.hasRelationship and then do the validation if its false.
| Future<void> _onAcceptButtonPressed() async { | ||
| final canCreateRelationship = await widget.validateCreateRelationship?.call(); | ||
|
|
||
| if (canCreateRelationship != null && !canCreateRelationship) return; |
There was a problem hiding this comment.
here you just return if it's not possible, what do I miss?
There was a problem hiding this comment.
inside the widget.validateCreateRelationship?.call() there the error dialog is called when it is not possible
…s://github.com/nmshd/app into check-if-establishing-relationship-is-possible
…s://github.com/nmshd/app into check-if-establishing-relationship-is-possible
Readiness checklist