Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test(files)/add performance tests #19

Merged
merged 22 commits into from
Feb 27, 2023
Merged

Test(files)/add performance tests #19

merged 22 commits into from
Feb 27, 2023

Conversation

JLSRKonk
Copy link
Contributor

No description provided.

@JLSRKonk JLSRKonk requested a review from tnotheis February 21, 2023 13:15
tnotheis
tnotheis reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@tnotheis tnotheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a partial review because I have to time to complete it right now. But I think that one of the comments is something that requires a bit more work, which is why I wanted to commit it right away.

tnotheis
tnotheis reviewed Feb 22, 2023
View reviewed changes
@JLSRKonk JLSRKonk requested a review from tnotheis February 22, 2023 14:52
tnotheis
tnotheis requested changes Feb 22, 2023
View reviewed changes
@JLSRKonk JLSRKonk requested a review from tnotheis February 22, 2023 16:15
tnotheis
tnotheis requested changes Feb 23, 2023
View reviewed changes
Copy link
Member

@tnotheis tnotheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't look into this PR for now. Please go through your code yourself to check if all comments from all the PRs are resolved and rerequest the review after you think they are.

@JLSRKonk JLSRKonk requested a review from tnotheis February 24, 2023 16:36
tnotheis
tnotheis requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@tnotheis tnotheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I just have one minor comment and two new ideas.

@JLSRKonk JLSRKonk requested a review from tnotheis February 27, 2023 11:09
@JLSRKonk JLSRKonk requested a review from tnotheis February 27, 2023 11:41
@JLSRKonk JLSRKonk requested a review from tnotheis February 27, 2023 12:33
@JLSRKonk JLSRKonk merged commit 6739efc into main Feb 27, 2023
@JLSRKonk JLSRKonk deleted the test(files)/performance-tests branch February 27, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis approved these changes

@daniel-almeida-konkconsulting daniel-almeida-konkconsulting Awaiting requested review from daniel-almeida-konkconsulting

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JLSRKonk @tnotheis