Fix compiler warnings related to nullability in Messages module

Modules/Messages/src/Messages.Application/Extensions/RecipientInformationIReadOnlyExtensions.cs

@@ -5,7 +5,7 @@ namespace Backbone.Modules.Messages.Application.Extensions;
 
 public static class RecipientInformationICollectionExtensions
 {
-    public static RecipientInformation FirstWithIdOrDefault(this IReadOnlyCollection<RecipientInformation> query, IdentityAddress address)
+    public static RecipientInformation? FirstWithIdOrDefault(this IReadOnlyCollection<RecipientInformation> query, IdentityAddress address)
     {
         return query.FirstOrDefault(r => r.Address == address);
     }

Modules/Messages/src/Messages.Application/Infrastructure/Persistence/BlobOptions.cs

@@ -2,5 +2,5 @@
 
 public class BlobOptions
 {
-    public string RootFolder { get; set; }
+    public string? RootFolder { get; set; }
 }

Modules/Messages/src/Messages.Application/Infrastructure/Persistence/Repository/IRelationshipsRepository.cs

@@ -3,7 +3,6 @@
 
 namespace Backbone.Modules.Messages.Application.Infrastructure.Persistence.Repository;
 
-#nullable enable
 public interface IRelationshipsRepository
 {
     Task<RelationshipId?> GetIdOfRelationshipBetweenSenderAndRecipient(IdentityAddress identityA, IdentityAddress identityB);

Modules/Messages/src/Messages.Application/Messages.Application.csproj

@@ -1,6 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-	<ItemGroup>
+    <PropertyGroup>
+        <Nullable>enable</Nullable>
+    </PropertyGroup>
+
+    <ItemGroup>
 		<PackageReference Include="AutoMapper.Extensions.Microsoft.DependencyInjection" Version="12.0.1" />
 		<PackageReference Include="FluentValidation.DependencyInjectionExtensions" Version="11.8.1" />
 	</ItemGroup>
@@ -10,4 +14,5 @@
 		<ProjectReference Include="..\..\..\..\BuildingBlocks\src\BuildingBlocks.Application\BuildingBlocks.Application.csproj" />
 		<ProjectReference Include="..\Messages.Domain\Messages.Domain.csproj" />
 	</ItemGroup>
+
 </Project>

Modules/Messages/src/Messages.Application/Messages/Commands/SendMessage/SendMessageCommand.cs

@@ -9,17 +9,17 @@ public class SendMessageCommand : IRequest<SendMessageResponse>
 {
     public ICollection<SendMessageCommandRecipientInformation> Recipients { get; set; } = new List<SendMessageCommandRecipientInformation>();
     public DateTime? DoNotSendBefore { get; set; }
-    public byte[] Body { get; set; }
+    public required byte[] Body { get; set; }
     public ICollection<SendMessageCommandAttachment> Attachments { get; set; } = new List<SendMessageCommandAttachment>();
 }
 
 public class SendMessageCommandRecipientInformation
 {
-    public IdentityAddress Address { get; set; }
-    public byte[] EncryptedKey { get; set; }
+    public required IdentityAddress Address { get; set; }
+    public required byte[] EncryptedKey { get; set; }
 }
 
 public class SendMessageCommandAttachment
 {
-    public string Id { get; set; }
+    public required string Id { get; set; }
 }

Modules/Messages/src/Messages.Application/Messages/Commands/SendMessage/SendMessageCommandValidator.cs

@@ -19,7 +19,7 @@ public SendMessageCommandValidator()
                 .SetValidator(new SendMessageCommandRecipientInformationValidator()));
 
         RuleFor(m => m.Recipients.Count)
-            .InclusiveBetween(1, 50).When(m => m.Recipients != null).WithErrorCode(GenericApplicationErrors.Validation.InvalidPropertyValue().Code);
+            .InclusiveBetween(1, 50).WithErrorCode(GenericApplicationErrors.Validation.InvalidPropertyValue().Code);
 
         RuleFor(m => m.Body).DetailedNotNull().NumberOfBytes(1, 10.Mebibytes());
 
@@ -29,7 +29,7 @@ public SendMessageCommandValidator()
                 .SetValidator(new SendMessageCommandAttachmentValidator()));
 
         RuleFor(m => m.Attachments.Count)
-            .InclusiveBetween(0, 20).When(m => m.Attachments != null).WithErrorCode(GenericApplicationErrors.Validation.InvalidPropertyValue().Code);
+            .InclusiveBetween(0, 20).WithErrorCode(GenericApplicationErrors.Validation.InvalidPropertyValue().Code);
     }
 }
 

Modules/Messages/src/Messages.Application/Messages/Commands/SendMessage/SendMessageResponse.cs

@@ -6,6 +6,6 @@ namespace Backbone.Modules.Messages.Application.Messages.Commands.SendMessage;
 
 public class SendMessageResponse : IMapTo<Message>
 {
-    public MessageId Id { get; set; }
+    public required MessageId Id { get; set; }
     public DateTime CreatedAt { get; set; }
 }

Modules/Messages/src/Messages.Application/Messages/DTOs/AttachmentDTO.cs

@@ -5,5 +5,5 @@ namespace Backbone.Modules.Messages.Application.Messages.DTOs;
 
 public class AttachmentDTO : IMapTo<Attachment>
 {
-    public string Id { get; set; }
+    public required string Id { get; set; }
 }

Modules/Messages/src/Messages.Application/Messages/DTOs/MessageDTO.cs

@@ -7,17 +7,17 @@ namespace Backbone.Modules.Messages.Application.Messages.DTOs;
 
 public class MessageDTO : IMapTo<Message>
 {
-    public MessageId Id { get; set; }
+    public required MessageId Id { get; set; }
 
     public DateTime CreatedAt { get; set; }
-    public IdentityAddress CreatedBy { get; set; }
-    public DeviceId CreatedByDevice { get; set; }
+    public required IdentityAddress CreatedBy { get; set; }
+    public required DeviceId CreatedByDevice { get; set; }
 
     public DateTime? DoNotSendBefore { get; set; }
-    public byte[] Body { get; set; }
+    public required byte[] Body { get; set; }
 
-    public List<AttachmentDTO> Attachments { get; set; }
-    public List<RecipientInformationDTO> Recipients { get; set; }
+    public required List<AttachmentDTO> Attachments { get; set; }
+    public required List<RecipientInformationDTO> Recipients { get; set; }
 
     public void PrepareForActiveIdentity(IdentityAddress activeIdentity)
     {

Modules/Messages/src/Messages.Application/Messages/DTOs/RecipientInformationDTO.cs

@@ -6,8 +6,8 @@ namespace Backbone.Modules.Messages.Application.Messages.DTOs;
 
 public class RecipientInformationDTO : IMapTo<RecipientInformation>
 {
-    public IdentityAddress Address { get; set; }
-    public byte[] EncryptedKey { get; set; }
+    public required IdentityAddress Address { get; set; }
+    public required byte[] EncryptedKey { get; set; }
     public DateTime? ReceivedAt { get; set; }
-    public DeviceId ReceivedByDevice { get; set; }
+    public DeviceId? ReceivedByDevice { get; set; }
 }

Modules/Messages/src/Messages.Application/Messages/Queries/GetMessage/GetMessageQuery.cs

@@ -6,6 +6,6 @@ namespace Backbone.Modules.Messages.Application.Messages.Queries.GetMessage;
 
 public class GetMessageQuery : IRequest<MessageDTO>
 {
-    public MessageId Id { get; init; }
+    public required MessageId Id { get; init; }
     public bool NoBody { get; init; }
 }

Modules/Messages/src/Messages.Common/Messages.Common.csproj

@@ -1,6 +1,10 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
-	<ItemGroup>
+    <PropertyGroup>
+        <Nullable>enable</Nullable>
+    </PropertyGroup>
+
+    <ItemGroup>
 		<PackageReference Include="FluentValidation" Version="11.8.1" />
 	</ItemGroup>
 

Modules/Messages/src/Messages.Common/Range.cs

@@ -10,17 +10,17 @@ public Range(T from, T to)
         To = to;
     }
 
-    public T From { get; set; }
-    public T To { get; set; }
+    public T From { get; set; } = default!;
+    public T To { get; set; } = default!;
 
     public bool HasFrom()
     {
-        return !From.Equals(default(T));
+        return Equals(From, default(T));
     }
 
     public bool HasTo()
     {
-        return !To.Equals(default(T));
+        return Equals(To, default(T));
     }
 }
 

Modules/Messages/src/Messages.Domain/Messages.Domain.csproj

@@ -1,10 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-	<PropertyGroup>
-		<Nullable>enable</Nullable>
-	</PropertyGroup>
+    <PropertyGroup>
+        <Nullable>enable</Nullable>
+    </PropertyGroup>
 
-	<ItemGroup>
+    <ItemGroup>
 		<ProjectReference Include="..\..\..\..\BuildingBlocks\src\DevelopmentKit.Identity\DevelopmentKit.Identity.csproj" />
 		<ProjectReference Include="..\..\..\..\BuildingBlocks\src\Tooling\Tooling.csproj" />
 	</ItemGroup>

Modules/Messages/src/Messages.Infrastructure.Database.Postgres/Messages.Infrastructure.Database.Postgres.csproj

@@ -1,11 +1,11 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
+    <PropertyGroup>
+        <Nullable>enable</Nullable>
+    </PropertyGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="..\Messages.Infrastructure\Messages.Infrastructure.csproj" />
-  </ItemGroup>
+    <ItemGroup>
+        <ProjectReference Include="..\Messages.Infrastructure\Messages.Infrastructure.csproj" />
+    </ItemGroup>
 
 </Project>

Modules/Messages/src/Messages.Infrastructure.Database.SqlServer/Messages.Infrastructure.Database.SqlServer.csproj

@@ -1,11 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
+    <PropertyGroup>
+        <Nullable>enable</Nullable>
+    </PropertyGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="..\Messages.Infrastructure\Messages.Infrastructure.csproj" />
-  </ItemGroup>
+    <ItemGroup>
+        <ProjectReference Include="..\Messages.Infrastructure\Messages.Infrastructure.csproj" />
+    </ItemGroup>
 
 </Project>

Modules/Messages/src/Messages.Infrastructure/EventBus/MessagesEventBusRabbitMQ.cs

@@ -7,7 +7,7 @@
 namespace Backbone.Modules.Messages.Infrastructure.EventBus;
 public class MessagesEventBusRabbitMq : EventBusRabbitMq, IMessagesEventBus
 {
-    public MessagesEventBusRabbitMq(IRabbitMqPersistentConnection persistentConnection, ILogger<EventBusRabbitMq> logger, ILifetimeScope autofac, IEventBusSubscriptionsManager subsManager, HandlerRetryBehavior handlerRetryBehavior, string queueName = null) : base(persistentConnection, logger, autofac, subsManager, handlerRetryBehavior, queueName)
+    public MessagesEventBusRabbitMq(IRabbitMqPersistentConnection persistentConnection, ILogger<EventBusRabbitMq> logger, ILifetimeScope autofac, IEventBusSubscriptionsManager subsManager, HandlerRetryBehavior handlerRetryBehavior, string? queueName = null) : base(persistentConnection, logger, autofac, subsManager, handlerRetryBehavior, queueName)
     {
     }
 }

Modules/Messages/src/Messages.Infrastructure/Messages.Infrastructure.csproj

@@ -1,6 +1,10 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
-	<ItemGroup>
+    <PropertyGroup>
+        <Nullable>enable</Nullable>
+    </PropertyGroup>
+
+    <ItemGroup>
 		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.0" />
 		<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.0" />
 		<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="8.0.0" />
@@ -12,4 +16,5 @@
 		<ProjectReference Include="..\Messages.Application\Messages.Application.csproj" />
 		<ProjectReference Include="..\Messages.Domain\Messages.Domain.csproj" />
 	</ItemGroup>
+
 </Project>

Modules/Messages/src/Messages.Infrastructure/Persistence/Database/IServiceCollectionExtensions.cs

@@ -53,8 +53,8 @@ public static void AddDatabase(this IServiceCollection services, DbOptions optio
 
 public class DbOptions
 {
-    public string Provider { get; set; }
-    public string DbConnectionString { get; set; }
+    public string Provider { get; set; } = null!;
+    public string DbConnectionString { get; set; } = null!;
     public RetryOptions RetryOptions { get; set; } = new();
 }
 

Modules/Messages/src/Messages.Infrastructure/Persistence/Database/MessagesDbContext.cs

@@ -3,6 +3,7 @@
 using Backbone.Modules.Messages.Domain.Ids;
 using Backbone.Modules.Messages.Infrastructure.Persistence.Database.ValueConverters;
 using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Internal;
 
 namespace Backbone.Modules.Messages.Infrastructure.Persistence.Database;
 
@@ -14,9 +15,9 @@ public MessagesDbContext(DbContextOptions<MessagesDbContext> options) : base(opt
 
     public MessagesDbContext(DbContextOptions<MessagesDbContext> options, IServiceProvider serviceProvider) : base(options, serviceProvider) { }
 
-    public virtual DbSet<Message> Messages { get; set; }
-    public virtual DbSet<RecipientInformation> RecipientInformation { get; set; }
-    public virtual DbSet<Relationship> Relationships { get; set; }
+    public virtual DbSet<Message> Messages { get; set; } = null!;
+    public virtual DbSet<RecipientInformation> RecipientInformation { get; set; } = null!;
+    public virtual DbSet<Relationship> Relationships { get; set; } = null!;
 
     protected override void ConfigureConventions(ModelConfigurationBuilder configurationBuilder)
     {

Modules/Messages/src/Messages.Infrastructure/Persistence/Database/Repository/RelationshipsRepository.cs

@@ -14,7 +14,6 @@ public RelationshipsRepository(MessagesDbContext dbContext)
         _dbContext = dbContext;
     }
 
-#nullable enable
     public Task<RelationshipId?> GetIdOfRelationshipBetweenSenderAndRecipient(IdentityAddress sender, IdentityAddress recipient)
     {
         return _dbContext.Relationships
@@ -23,5 +22,4 @@ public RelationshipsRepository(MessagesDbContext dbContext)
             .Select(r => r.Id)
             .FirstOrDefaultAsync();
     }
-#nullable disable
 }

Modules/Messages/src/Messages.Infrastructure/Persistence/Database/ValueConverters/FileIdEntityFrameworkValueConverter.cs

@@ -7,7 +7,7 @@ public class FileIdEntityFrameworkValueConverter : ValueConverter<FileId, string
 {
     public FileIdEntityFrameworkValueConverter() : this(null) { }
 
-    public FileIdEntityFrameworkValueConverter(ConverterMappingHints mappingHints)
+    public FileIdEntityFrameworkValueConverter(ConverterMappingHints? mappingHints)
         : base(
             id => id == null ? null : id.StringValue,
             value => FileId.Parse(value),

Modules/Messages/src/Messages.Infrastructure/Persistence/Database/ValueConverters/MessageIdEntityFrameworkValueConverter.cs

@@ -7,7 +7,7 @@ public class MessageIdEntityFrameworkValueConverter : ValueConverter<MessageId,
 {
     public MessageIdEntityFrameworkValueConverter() : this(null) { }
 
-    public MessageIdEntityFrameworkValueConverter(ConverterMappingHints mappingHints)
+    public MessageIdEntityFrameworkValueConverter(ConverterMappingHints? mappingHints)
         : base(
             id => id == null ? null : id.StringValue,
             value => MessageId.Parse(value),

Modules/Messages/src/Messages.Infrastructure/Persistence/Database/ValueConverters/RelationshipIdEntityFrameworkValueConverter.cs

@@ -7,7 +7,7 @@ public class RelationshipIdEntityFrameworkValueConverter : ValueConverter<Relati
 {
     public RelationshipIdEntityFrameworkValueConverter() : this(null) { }
 
-    public RelationshipIdEntityFrameworkValueConverter(ConverterMappingHints mappingHints)
+    public RelationshipIdEntityFrameworkValueConverter(ConverterMappingHints? mappingHints)
         : base(
             id => id == null ? null : id.StringValue,
             value => RelationshipId.Parse(value),