Admin UI: Encountering infinite loading when entering non-existent identity/client/tier ids in URL #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…y-Client-Tier-ID-in-URL' of https://github.com/nmshd/backbone into NMSHDB-198-Problem-when-specifying-non-existent-Identity-Client-Tier-ID-in-URL
…y-Client-Tier-ID-in-URL' of https://github.com/nmshd/backbone into NMSHDB-198-Problem-when-specifying-non-existent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
jkoenig134
reviewed
Sep 3, 2024
Applications/AdminUi/apps/admin_ui/lib/home/client_details/client_details.dart
Outdated
Show resolved
Hide resolved
jkoenig134
reviewed
Sep 3, 2024
Applications/AdminUi/apps/admin_ui/lib/screens/error_screen.dart
Outdated
Show resolved
Hide resolved
|
I think I said that several times already, but: titles of PRs with the label Also: why does this PR have the label |
stamenione
changed the title
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
…ent-Identity-Client-Tier-ID-in-URL
|
A manual test was successful. @jkoenig134 If you don't have anything to add, I'm okay with merging it. |
tnotheis
approved these changes
Sep 20, 2024
|
Looks fine for me. |
jkoenig134
approved these changes
Sep 20, 2024
stamenione
deleted the
NMSHDB-198-Problem-when-specifying-non-existent-Identity-Client-Tier-ID-in-URL
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
Button "Find" is now disabled if the input field is empty. I found that problem when testing this endpoint "/api/v1/Identities/{identityAddress}/DeletionProcesses/AuditLogs", and the test case was the empty string that could be entered.
This is the Dark mode version of error screen.
The Light version.
