Migrate creation of an Identity and registration of a Device domain appropriate logic from Handler to Domain #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-almeida-konkconsulting
suggested changes
Sep 30, 2024
Modules/Devices/src/Devices.Application/Devices/Commands/RegisterDevice/Validator.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Application/Extensions/ValidatorExtensions.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Application/Identities/Commands/CreateIdentity/Validator.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/test/Devices.Domain.Tests/Domain/DeviceTests.cs
Outdated
Show resolved
Hide resolved
… of https://github.com/nmshd/backbone into nmshdb-160-migrate-createIdentity-registerDevice-logic
… of https://github.com/nmshd/backbone into nmshdb-160-migrate-createIdentity-registerDevice-logic
tnotheis
requested changes
Oct 2, 2024
Modules/Devices/src/Devices.Application/Devices/Commands/RegisterDevice/Validator.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Application/Identities/Commands/CreateIdentity/Handler.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Domain/Entities/Identities/Device.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/test/Devices.Infrastructure.Tests/TestDataGenerator.cs
Outdated
Show resolved
Hide resolved
… of https://github.com/nmshd/backbone into nmshdb-160-migrate-createIdentity-registerDevice-logic
tnotheis
approved these changes
Oct 2, 2024
NikolaDmitrasinovic
deleted the
nmshdb-160-migrate-createIdentity-registerDevice-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
Handler logic that should have been located in domain is now migrated appropriately. As a result, constructors were changes/added to respectful entity classes.
In addition validator logic for
CommunicationLanguagewas added.