Conversation
Simplified support for 1D and 2D meshes by automatically expanding point coordinate arrays to 3 components in the HDF5 output. This is achieved by: - Adding H5Pset_fill_value to the HDF5 bindings. - Enhancing h5_write_dataset and write_dataset_common to support an optional force_leading_dims argument and set a zero fill value. - Updating write_mesh to use these new features for the 'Points' dataset. - Adding a new test case for 2D meshes. This allows users with 1D or 2D meshes to pass their coordinate arrays directly without manually adding dummy components. Co-authored-by: nncarlson <7231327+nncarlson@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Simplified support for 1D and 2D meshes by automatically expanding point coordinate arrays to 3 components in the HDF5 output.
Key changes:
H5Pset_fill_valuetovtkhdf_h5_c_binding.F90.h5_write_datasetandwrite_dataset_commoninsrc/vtkhdf_h5.F90.fyppto accept an optionalforce_leading_dimsargument. When present, the library creates a dataset with these leading dimensions and writes the provided array into a slice. A zero fill value is used to ensure unwritten components are initialized to 0.write_meshinsrc/vtkhdf_ug_type.F90.fyppto useforce_leading_dims=[3_hsize_t]for the 'Points' dataset.test/vtkhdf_2d_test.F90and updatedtest/CMakeLists.txtto verify the new functionality.Fixes #14
PR created automatically by Jules for task 10752117872873327314 started by @nncarlson