Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint for code linting #342

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Add eslint for code linting #342

merged 2 commits into from
Jun 29, 2024

Conversation

niley7464
Copy link
Contributor

This PR adds eslint config and applies it.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 18, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #342. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@niley7464
Copy link
Contributor Author

niley7464 commented Jun 18, 2024

nnstreamer-example/Tizen.web/ImageClassificationOffloading/js/main.js
   83:24  error  'tizen' is not defined              no-undef
   91:17  error  'tizen' is not defined              no-undef
  113:22  error  'tizen' is not defined              no-undef
  133:15  error  'tizen' is not defined              no-undef
  136:23  error  'tizen' is not defined              no-undef
  195:9   error  'tizen' is not defined              no-undef
  196:16  error  'ignore' is defined but never used  no-unused-vars
  196:24  error  Empty block statement               no-empty

nnstreamer-example/Tizen.web/ImageClassificationOffloading/js/utils.js
  15:32  error  'reject' is defined but never used  no-unused-vars
  16:5   error  'tizen' is not defined              no-undef
  28:32  error  'reject' is defined but never used  no-unused-vars
  29:5   error  'tizen' is not defined              no-undef
  71:19  error  'tizen' is not defined              no-undef

nnstreamer-example/Tizen.web/ImageClassificationPipeline/js/main.js
   56:17  error  'tizen' is not defined              no-undef
   70:22  error  'tizen' is not defined              no-undef
   85:17  error  'tizen' is not defined              no-undef
  109:9   error  'tizen' is not defined              no-undef
  110:16  error  'ignore' is defined but never used  no-unused-vars
  110:24  error  Empty block statement               no-empty
  121:21  error  'tizen' is not defined              no-undef
  126:29  error  'tizen' is not defined              no-undef

nnstreamer-example/Tizen.web/ImageClassificationSingleShot/js/main.js
   56:17  error  'tizen' is not defined              no-undef
   71:15  error  'tizen' is not defined              no-undef
   88:9   error  'tizen' is not defined              no-undef
   89:16  error  'ignore' is defined but never used  no-unused-vars
   89:24  error  Empty block statement               no-empty
  100:29  error  'tizen' is not defined              no-undef

There are lots of error left which could not fixed by --fix option.
I just used recommended configs, so we need to set specific option for Tizen.web too.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niley7464, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niley7464, 💯 All CI checkers are successfully verified. Thanks.

@@ -0,0 +1,1057 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really need this file added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch adds eslint config.

Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
This patch applies eslint with --fix option and adds some error handling.

Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niley7464, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo myungjoo merged commit cffb212 into nnstreamer:main Jun 29, 2024
29 checks passed
@niley7464 niley7464 deleted the eslint branch July 1, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants