[coverity] fix coverity issues

- Added const auto & to avoid copy of an object - Added missing lock Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
nnstreamer · Mar 26, 2024 · f924faa · f924faa
1 parent c625cdc
commit f924faa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/nntrainer/dataset/iteration_queue.cpp b/nntrainer/dataset/iteration_queue.cpp
@@ -173,9 +173,11 @@ IterationQueue::MarkableIteration::MarkableIteration(
   iq(iq) {}
 
 IterationQueue::MarkableIteration::MarkableIteration(MarkableIteration &&rhs) :
-  num_observed(rhs.num_observed),
   iteration(std::move(rhs.iteration)),
-  iq(rhs.iq) {}
+  iq(rhs.iq) {
+  std::lock_guard notify_lock_guard(notify_mutex);
+  num_observed = rhs.num_observed;
+}
 
 void IterationQueue::MarkableIteration::reset() {
   std::lock_guard notify_lock_guard(notify_mutex);

diff --git a/test/unittest/models/models_test_utils.cpp b/test/unittest/models/models_test_utils.cpp
@@ -142,8 +142,11 @@ class IterationForGolden {
     auto to_tensors = [](sharedConstTensors &sts) {
       std::vector<Tensor> ts;
       ts.reserve(sts.size());
-      std::transform(sts.begin(), sts.end(), std::back_inserter(ts),
-                     [](const auto &ts) { return *ts; });
+      std::transform(
+        sts.begin(), sts.end(),
+        std::back_inserter(ts), [](const auto &ts) -> const auto & {
+          return *ts;
+        });
       return ts;
     };