Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorV2] Tensor element summation by axes feature #2483

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

djeong20
Copy link
Contributor

This pull request introduces a new feature that enables the summation of tensor elements by axes.
This feature allows users to sum up tensor values along specified axes, making it easier to perform complex mathematical operations involving tensors.

Changes proposed in this PR:

  • Added new function sum() that takes a tensor and an axis as input and returns the sum of all elements along that axis.
  • Added mergeAxis feature which merges the two axes for tensor into one.

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link

taos-ci commented Feb 22, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2483. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

@djeong20 djeong20 marked this pull request as ready for review February 23, 2024 05:55
@djeong20 djeong20 changed the title [WIP][TensorV2] Tensor element summation by axes feature [TensorV2] Tensor element summation by axes feature Feb 23, 2024
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

@djeong20 djeong20 added the PR/OK2GO CI failed but okay to merge/review label Feb 26, 2024
Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

skykongkong8

This comment was marked as duplicate.

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This pull request introduces a new feature that enables the summation of tensor elements by axes.
This feature allows users to sum up tensor values along specified axes, making it easier to perform complex mathematical operations involving tensors.

**Changes proposed in this PR:**
- Added new function sum() that takes a tensor and an axis as input and returns the sum of all elements along that axis.
- Added mergeAxis feature which merges the two axes for tensor into one.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <dhyeon.jeong@samsung.com>
@djeong20 djeong20 force-pushed the feat/tensor_v2/sum branch from c48a764 to e197813 Compare March 4, 2024 08:54
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

@jijoongmoon jijoongmoon merged commit 08b674a into nnstreamer:main Mar 4, 2024
27 of 29 checks passed
@djeong20 djeong20 deleted the feat/tensor_v2/sum branch March 20, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/OK2GO CI failed but okay to merge/review PR/READY2MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants