Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorV2] Feature Scaling Functions @open sesame 03/14 11:49 #2495

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

djeong20
Copy link
Contributor

@djeong20 djeong20 commented Mar 4, 2024

This pull request adds two new feature scaling functions - standardization and normalization - to the Tensor class.
These functions help users preprocess input data before feeding it into models, improving model performance and accuracy.

Changes proposed in this PR:

  • Added normalization() function to rescale values to a range between 0 and 1
  • Added standardization() function to center data around the mean and scales to a standard deviation of 1

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link

taos-ci commented Mar 4, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2495. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

@djeong20 djeong20 force-pushed the feat/tensor_v2/feat_scaling branch from 79244a3 to 8fa2334 Compare March 4, 2024 23:38
@djeong20 djeong20 changed the title [Wait for #2483][TensorV2] Feature Scaling Functions [TensorV2] Feature Scaling Functions Mar 4, 2024
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhs8928 lhs8928 changed the title [TensorV2] Feature Scaling Functions [TensorV2] Feature Scaling Functions @open sesame 03/07 10:28 Mar 7, 2024
@lhs8928 lhs8928 changed the title [TensorV2] Feature Scaling Functions @open sesame 03/07 10:28 [TensorV2] Feature Scaling Functions @open sesame 03/07 10:38 Mar 7, 2024
@taos-ci
Copy link

taos-ci commented Mar 7, 2024

:octocat: cibot: @djeong20, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2495-202403071037470.18874001502991-8fa23345f5d4b27d4a78d9d67affa269f43b300e/.

@DonghakPark DonghakPark changed the title [TensorV2] Feature Scaling Functions @open sesame 03/07 10:38 [TensorV2] Feature Scaling Functions @open sesame 03/07 11:08 Mar 7, 2024
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

@djeong20 djeong20 force-pushed the feat/tensor_v2/feat_scaling branch from 8fa2334 to 2f99e56 Compare March 7, 2024 05:31
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

@djeong20 djeong20 force-pushed the feat/tensor_v2/feat_scaling branch from 2f99e56 to 734928b Compare March 8, 2024 05:03
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This pull request adds two new feature scaling functions - standardization and normalization - to the Tensor class. These functions help users preprocess input data before feeding it into models, improving model performance and accuracy.

**Changes proposed in this PR:**
* Added normalization() function to rescale values to a range between 0 and 1
* Added standardization() function to center data around the mean and scales to a standard deviation of 1

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <dhyeon.jeong@samsung.com>
This commit integrated all remaining functions from Tensor class into TensorV2.
This includes fill(), setData(), setValueInt(), sin(), and cos().

Signed-off-by: Donghyeon Jeong <dhyeon.jeong@samsung.com>
@djeong20 djeong20 force-pushed the feat/tensor_v2/feat_scaling branch from 734928b to 542cdd7 Compare March 14, 2024 02:47
@djeong20 djeong20 changed the title [TensorV2] Feature Scaling Functions @open sesame 03/07 11:08 [TensorV2] Feature Scaling Functions @open sesame 03/14 11:49 Mar 14, 2024
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20, 💯 All CI checkers are successfully verified. Thanks.

@jijoongmoon jijoongmoon merged commit 6c8acb7 into nnstreamer:main Mar 14, 2024
29 of 31 checks passed
@djeong20 djeong20 deleted the feat/tensor_v2/feat_scaling branch March 20, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants