Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ WIP ][ Wait for #2648 ][ layer ] Custom Multi Head Attention layer #2650

Closed
wants to merge 3 commits into from
Closed

[ WIP ][ Wait for #2648 ][ layer ] Custom Multi Head Attention layer #2650

wants to merge 3 commits into from

Conversation

s-debadri
Copy link
Contributor

@s-debadri s-debadri commented Jun 25, 2024 •
edited
Loading

Changes made in this PR:

  • Added CustomMultiHeadAttentionLayerCl class with GPU implementation of custom MHA from FELICE repo.
  • Added API endpoint CustomMultiHeadAttention and required enums.
  • Modified cl_context to register custom MHA.

Work In Progress:

  • Incorporate addition OpenCL kernel
  • Add BiQGEMM OpenCL kernel

Signed-off-by: Debadri Samaddar s.debadri@samsung.com

s-debadri added 2 commits June 20, 2024 12:48
@s-debadri
[blas/OpenCL] Added multiply OpenCL kernel and unit test
8baf1c6 
Added sscal equivalent kernel and multiply function.
Added unit test setup to test standalone kernels.

Signed-off-by: Debadri Samaddar <s.debadri@samsung.com>
@s-debadri
[blas/opencl] SGEMM OpenCL kernels added
9c8e874 
Added all possible OpenCL kernels for SGEMM
Added unit tests

Signed-off-by: Debadri Samaddar <s.debadri@samsung.com>
@taos-ci
Copy link

taos-ci commented Jun 25, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2650. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link

taos-ci commented Jun 25, 2024

:octocat: cibot: @s-debadri, nntrainer/layers/custom_multi_head_attention_layer.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@s-debadri s-debadri changed the title [ WIP ][ layer ] Custom Multi Head Attention layer [ WIP ][ Wait for #2648 ][ layer ] Custom Multi Head Attention layer Jun 25, 2024
@taos-ci
Copy link

taos-ci commented Jun 25, 2024

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2650-202406251521590.086549997329712-1a28a52e2fd5702a2bd8940e130b5b515865a8df/.

@s-debadri s-debadri force-pushed the custom_mha branch 2 times, most recently from 2d509e3 to 841c142 Compare June 25, 2024 06:58
@taos-ci
Copy link

taos-ci commented Jun 25, 2024

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2650-202406251558170.7800760269165-841c14247caf0bc3e2d15f140d299a26b5ddc5a7/.

@taos-ci
Copy link

taos-ci commented Jun 26, 2024

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2650-202406261917230.12148904800415-17b2ecf7f09e068719dedb8b6a9fb9dc46840bb2/.

@s-debadri
[layer] Added GPU implementation of custom MHA attention layer
38617fe 
GPU implementation of custom MHA layer

Signed-off-by: Debadri Samaddar <s.debadri@samsung.com>
@taos-ci
Copy link

taos-ci commented Jul 3, 2024

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2650-202407031816100.44195008277893-38617fe195c419773bd664aed2bd9308d602c7d6/.

@s-debadri
Copy link
Contributor Author

Another clean PR raised for the same: #2671

@s-debadri s-debadri closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo will be requested when the pull request is marked ready for review myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon will be requested when the pull request is marked ready for review jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you will be requested when the pull request is marked ready for review again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung will be requested when the pull request is marked ready for review jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs will be requested when the pull request is marked ready for review leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong will be requested when the pull request is marked ready for review wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang will be requested when the pull request is marked ready for review gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 will be requested when the pull request is marked ready for review anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 will be requested when the pull request is marked ready for review lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot will be requested when the pull request is marked ready for review songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu will be requested when the pull request is marked ready for review jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark will be requested when the pull request is marked ready for review DonghakPark is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun will be requested when the pull request is marked ready for review SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm will be requested when the pull request is marked ready for review baek2sm is a code owner

@skykongkong8 skykongkong8 Awaiting requested review from skykongkong8 skykongkong8 will be requested when the pull request is marked ready for review skykongkong8 is a code owner

@djeong20 djeong20 Awaiting requested review from djeong20 djeong20 will be requested when the pull request is marked ready for review djeong20 is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang will be requested when the pull request is marked ready for review EunjuYang is a code owner

@dkjung dkjung Awaiting requested review from dkjung dkjung will be requested when the pull request is marked ready for review dkjung is a code owner

@haehun haehun Awaiting requested review from haehun haehun will be requested when the pull request is marked ready for review haehun is a code owner

Assignees
No one assigned
Labels
Need Review rebase required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-debadri @taos-ci @djeong20