[ meson ] remove hard code path in meson script @open sesame 12/23 15:55 #2833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EunjuYang
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8 and
djeong20
as code owners
myungjoo
reviewed
Dec 19, 2024
meson.build
Outdated
| # This meson tries to find its installation. | ||
| # 1. Checking /usr/include/ | ||
| # 2. Checking path meson-option specifies | ||
| biqgemm_path = '/usr/include/BiQGEMM' |
There was a problem hiding this comment.
Refer to https://mesonbuild.com/Builtin-options.html
biggemm_path = join_paths(prefix, includedir, `BiQGEMM`)
If someone cross-compiles nntrainer with biqgemm, this is going to be critical.
myungjoo
reviewed
Dec 19, 2024
nntrainer/tensor/meson.build
Outdated
| @@ -80,7 +80,7 @@ if get_option('enable-biqgemm') | |||
| tensor_headers += 'bcq_tensor.h' | |||
| tensor_sources += 'bcq_tensor.cpp' | |||
| nntrainer_inc += biqgemm_inc | |||
| nntrainer_inc_abs += meson.source_root() / '..' / 'BiQGEMM' | |||
| nntrainer_inc_abs += meson.source_root() / biqgemm_path | |||
There was a problem hiding this comment.
fs = import('fs')
if fs.is_absolete(biqgemm_path)
nntrainer_inc_abs += biqgemm_path
else
nntrainer_inc_abs += meson.source_root() / biqgemm_path
endif
There was a problem hiding this comment.
Thank you for the review. I missed the case. I updated the commit based on your comments. Thank you :)
EunjuYang
force-pushed
the
build/biqgemm_dependency
branch
from
f6ac831 to
3f4b6b4
Compare
- In the previous version, meson.build contains absolute path for the BiQGEMM enablement, which is undesirable. - This commit updates the meson build script including the top meson and tensor meson by adding meson_option and the step to search the default path. Self-evaluation: Build test: [X]Passed [ ]Failed [ ]Skipped Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Eunju Yang <ej.yang@samsung.com>
EunjuYang
force-pushed
the
build/biqgemm_dependency
branch
from
3f4b6b4 to
ba5447c
Compare
djeong20
approved these changes
Dec 23, 2024
myungjoo
approved these changes
Dec 23, 2024
EunjuYang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-evaluation:
Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped