[RunLayerContext] Unused property and its relevant methods are removed #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EunjuYang
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8 and
djeong20
as code owners
myungjoo
reviewed
Jan 2, 2025
| * @return ompute engine: (CPU/GPU) | ||
| */ | ||
| ml::train::LayerComputeEngine getComputeEngine() { return compute_engine; } | ||
|
|
There was a problem hiding this comment.
You still have:
nntrainer/nntrainer/layers/layer_context.h
Lines 946 to 947 in 079f57a
There was a problem hiding this comment.
Thank you for the comment! I've updated it :)
- This commit removes unused property and its relevant methods in RunLayerContext. - compute_engine info is not handled in RunLayerContext. Signed-off-by: Eunju Yang <ej.yang@samsung.com>
EunjuYang
force-pushed
the
remove/unused_code
branch
from
079f57a to
6e383f4
Compare
myungjoo
approved these changes
Jan 2, 2025
SeoHyungjun
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
LGTM👍
In PR #2848, layer_node was modified, but layer_context seems not to have been modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstact
This PR removes unused
compute_engineproperty inRunLayerContext. The property has been unused, and it seems not to be used later as well. The compute_engine-related property seems to be handled inContextonly. [refer to #2848]List of commits
Self evaluation: