Skip to content

[trivial] Update CODEOWNERS #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

[trivial] Update CODEOWNERS #2871

merged 1 commit into from
Jan 15, 2025

Conversation

dkjung
Copy link
Collaborator

@dkjung dkjung commented Jan 14, 2025 •
edited
Loading

Modify CODEOWNERS

Changes proposed in this PR:

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [*]Skipped
  2. Run test: [X]Passed [ ]Failed [*]Skipped

How to evaluate:

  1. NA

haehun
haehun approved these changes Jan 14, 2025
View reviewed changes
Copy link

@haehun haehun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating CODEOWNERS. LGTM!

skykongkong8
skykongkong8 reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@skykongkong8 skykongkong8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your commit hasn't signed off.
You need something like:

**Self evaluation:**
    1. Build test:     [X]Passed [ ]Failed [ ]Skipped
    2. Run test:     [X]Passed [ ]Failed [ ]Skipped
    
    Signed-off-by: skykongkong8 <ss.kong@samsung.com>

in your commit msg to pass the CI

EunjuYang
EunjuYang reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@EunjuYang EunjuYang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the signing off guide, please refer to this page, [contributing.md] :)

@skykongkong8 skykongkong8 mentioned this pull request Jan 14, 2025
Merged
DonghakPark
DonghakPark approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

djeong20
djeong20 reviewed Jan 14, 2025
View reviewed changes
@dkjung dkjung changed the title Update CODEOWNERS [trivial] Update CODEOWNERS Jan 14, 2025
@dkjung
Update CODEOWNERS
020dd52 
Remove ineligible users
- @nnstreamer/nnstreamer
- @helloahn
- @kparichay
- @dongju-chae
- @zhoonit

Add a new user
- @dkjung
- @haehun

Signed-off-by: Daekyoung Jung <dk11.jung@samsung.com>
@dkjung
Copy link
Collaborator Author

dkjung commented Jan 14, 2025

I think your commit hasn't signed off. You need something like:

**Self evaluation:**
    1. Build test:     [X]Passed [ ]Failed [ ]Skipped
    2. Run test:     [X]Passed [ ]Failed [ ]Skipped
    
    Signed-off-by: skykongkong8 <ss.kong@samsung.com>

in your commit msg to pass the CI

Thanks, I signed it off.

baek2sm
baek2sm approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon
Copy link
Collaborator

You also need signed-off in comment of this PR as well.
Signed-off-by: Daekyoung Jung dk11.jung@samsung.com

@myungjoo myungjoo merged commit abaa191 into nnstreamer:main Jan 15, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeong20 djeong20 djeong20 left review comments

@myungjoo myungjoo myungjoo approved these changes

@haehun haehun haehun approved these changes

@EunjuYang EunjuYang EunjuYang approved these changes

@baek2sm baek2sm baek2sm approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dkjung @jijoongmoon @myungjoo @haehun @EunjuYang @baek2sm @DonghakPark @djeong20 @skykongkong8