Improve subsetting robustness by using triangle for buffer meshing
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SorooshMani-NOAA
force-pushed
the
enhance/subset_triangle
branch
from
8b30231
to
0d1eb80
Compare
This was
linked to
issues
Sep 21, 2023
Open
Comment on lines
+196
to
+201
| elm_polys = [] | ||
| for elm_type in ELEM_2D_TYPES: | ||
| elems = getattr(mesh, elm_type)['index'] | ||
| elm_polys.extend( | ||
| [Polygon(mesh.vert2['coord'][cell]) for cell in elems] | ||
| ) |
There was a problem hiding this comment.
Old polygon from mesh sometimes failed randomly for cases where two separate polygons are touching at multiple forms, forming islands between them
There was a problem hiding this comment.
This method might be slower and/or more memory hungry (not tested) but it is correct!
|
The subset and combine functionality has been also tested by @FariborzDaneshvar-NOAA and @yichengt900 as a part of the on demand workflow for storm simulation for storms including Irene 2011, Harvey 2017, Florence 2018, Ian 2022. The only remaining issue to address is #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to pin python to
3.11due to issues with building current version#57d988f (tag: v20220202)of triangle.The fix is already in the package, but they just need to release it to PyPI .
Update
A new version of
triangleis not released on PyPI, so no need to pin to pre3.11python