Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Simplify StringDNSLabel rule #29

Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore: Simplify StringDNSLabel rule #29

merged 2 commits into from
Oct 1, 2024

Conversation

nieomylnieja
Copy link
Collaborator

Motivation

There's no need for StringDNSLabel to be a RuleSet, we can ensure the proper length with regular expression.

Breaking Changes

StringDNSLabel is no longer a RuleSet, instead it's now a single Rule.

@n9-machine-user n9-machine-user added breaking-change Any kind of non-backwards compatible change chore Routine or minor duty task go Pull requests that update Go code patch Bug fixes and security updates labels Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Test coverage changes:

Package Before After Diff
github.com/nobl9/govy/cmd/govy 19% 19% ✔️
github.com/nobl9/govy/internal 38% 38% ✔️
github.com/nobl9/govy/internal/examples 30% 30% ✔️
github.com/nobl9/govy/internal/nameinfer 15% 15% ✔️
github.com/nobl9/govy/pkg/govy 84% 84% ✔️
github.com/nobl9/govy/pkg/govyconfig 68% 68% ✔️
github.com/nobl9/govy/pkg/govytest 57% 57% ✔️
github.com/nobl9/govy/pkg/rules 83% 83% ✔️

@nieomylnieja nieomylnieja merged commit 364a5a5 into main Oct 1, 2024
6 checks passed
@nieomylnieja nieomylnieja deleted the simplify-string-dns-label-rule branch October 1, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Any kind of non-backwards compatible change chore Routine or minor duty task go Pull requests that update Go code patch Bug fixes and security updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nieomylnieja @n9-machine-user