PC-8951 optimize mem usage by IsDNS1123Label func #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IsDNS1123Label function in v1alpha/validator package compiled the regexp for every call. Now compiling the regexp for validation DNS label is static.
mkaras-nobl9
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-check
Motivation
The
IsDNS1123Labelfunction in v1alpha/validator package compiled the regexp for every call. Now compiling the regexp for validation DNS label is static.Summary
before:
after:
