Skip to content

Commit

Permalink
fix: Unquote ldflags in Release workflow (#41)
Browse files Browse the repository at this point in the history
## Motivation

`LDFLAGS` Docker argument should not be quoted since this causes:

```
invalid value "'-s -w -X github.com/nobl9/sloctl/internal.BuildVersion=v0.0.98'" for flag -ldflags: parameter may not start with quote character '
```
  • Loading branch information
nieomylnieja authored Feb 7, 2024
1 parent 88c544d commit 432949a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ jobs:
platforms: linux/amd64, linux/arm64
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
build-args: LDFLAGS='-s -w -X github.com/nobl9/sloctl/internal.BuildVersion=${{ github.ref_name }}'
build-args: LDFLAGS=-s -w -X github.com/nobl9/sloctl/internal.BuildVersion=${{ github.ref_name }}

0 comments on commit 432949a

Please sign in to comment.