Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bring back get alerts project flags #186

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: Bring back get alerts project flags #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ var projectFlagSupportingKinds = map[manifest.Kind]struct{}{
manifest.KindDataExport: {},
manifest.KindRoleBinding: {},
manifest.KindAnnotation: {},
// While Alert itself is not Project scoped per-se,
// it does support Project filtering.
manifest.KindAlert: {},
}

func objectKindSupportsProjectFlag(kind manifest.Kind) bool {
Expand Down
2 changes: 1 addition & 1 deletion internal/get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ func (g *GetCmd) newGetAlertCommand(cmd *cobra.Command) *cobra.Command {
return err
}
if len(objects) == 0 {
fmt.Printf("No resources found.\n")
fmt.Printf("No resources found in '%s' project.\n", g.client.Config.Project)
return nil
}
if err = g.printObjects(objects); err != nil {
Expand Down
Loading