fix: Add project flag back again for sloctl replay #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrolikiewicz
approved these changes
Aug 20, 2024
labtom
approved these changes
Aug 20, 2024
Co-authored-by: Tomek Labuk <89924840+labtom@users.noreply.github.com>
Co-authored-by: Tomek Labuk <89924840+labtom@users.noreply.github.com>
Co-authored-by: Tomek Labuk <89924840+labtom@users.noreply.github.com>
Co-authored-by: Tomek Labuk <89924840+labtom@users.noreply.github.com>
|
lgtm 🎸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#177 removed default project flags, unfortunately we missed the
sloctl replaycommand which also relied on them.This PR brings the
-pflag back forsloctl replaycommand.Release Notes
Adds
-pflag forsloctl replay, the flag was removed in v0.4.0 as a result of regression.