Skip to content

Commit

Permalink
chore: Fix release workflow (#168)
Browse files Browse the repository at this point in the history
## Motivation

Turns out reusable workflow cannot be called from the step level but
instead must be be called from job level.
  • Loading branch information
nieomylnieja authored Feb 15, 2024
1 parent 0d02d75 commit bee64e6
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/release-candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@ jobs:
uses: ./.github/workflows/acc-tests.yml
with:
clientId: "${{ vars.TERRAFORM_NOBL9_CLIENT_ID }}"
project: "${{ vars.TERRAFORM_NOBL9_PROJECT }}"
secrets:
clientSecret: "${{ secrets.TERRAFORM_NOBL9_CLIENT_SECRET }}"
14 changes: 8 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,16 @@ on:
- "v[0-9]+.[0-9]+.[0-9]+-beta"
- "v[0-9]+.[0-9]+.[0-9]+-alpha"
jobs:
test:
uses: ./.github/workflows/acc-tests.yml
with:
clientId: "${{ vars.TERRAFORM_NOBL9_CLIENT_ID }}"
project: "${{ vars.TERRAFORM_NOBL9_PROJECT }}"
secrets:
clientSecret: "${{ secrets.TERRAFORM_NOBL9_CLIENT_SECRET }}"
goreleaser:
runs-on: ubuntu-latest
needs: test
steps:
- name: Checkout
uses: actions/checkout@v4.1.1
Expand All @@ -37,12 +45,6 @@ jobs:
passphrase: ${{ secrets.PASSPHRASE }}
- name: setup github
run: git config --global url."https://n9-machine-user:${{ secrets.GH_TOKEN }}@github.com".insteadOf "https://github.com"
- name: Run acceptance tests
uses: ./.github/workflows/acc-tests.yml
with:
clientId: ${{ vars.TERRAFORM_NOBL9_CLIENT_ID }}
clientSecret: ${{ secrets.TERRAFORM_NOBL9_CLIENT_SECRET }}
project: ${{ vars.TERRAFORM_NOBL9_PROJECT }}
- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v5.0.0
with:
Expand Down

0 comments on commit bee64e6

Please sign in to comment.