test: PC-13893 Make acceptance test forward compatible #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditrytus
requested review from
skrolikiewicz,
nieomylnieja,
daniel-zelazny and
BSski
as code owners
piotrkwarcinski
approved these changes
Sep 23, 2024
ditrytus
added a commit
to nobl9/nobl9-go
that referenced
this pull request
Sep 23, 2024
## Motivation `value` field of `objective` for Composite SLO is being [deprecated](#549). Before the update in SDK can be made, a N9 platform first needs to be [updated](nobl9/n9#15406). To be able to release changes in the platform, e2e tests of the latest released SDK need to pass against it. ## Summary E2E test assertions will pass with and without [changes](nobl9/n9#15406) in N9 platform. ## Related changes #551 #549 nobl9/n9#15406 nobl9/terraform-provider-nobl9#312 nobl9/terraform-provider-nobl9#295 ## Testing Run `make test/e2e` on both environments containing and not containing nobl9/n9#15406.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
valuefield ofobjectivefor Composite SLO is being deprecated. Before the update in can be made, a N9 platform first needs to be updated and new version of SDK needs to be released. To be able to release changes in the platform, e2e tests of the latest released SDK and Terraform Provider need to pass against it.Summary
E2E test assertions will pass with and without changes in N9 platform.
Related changes
nobl9/nobl9-go#551
nobl9/nobl9-go#549
https://github.com/nobl9/n9/pull/15406
#312
#295
Testing
Run
make test/e2eon both environments containing and not containing https://github.com/nobl9/n9/pull/15406.