Add a converter specified shortcut #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a shortcut specified by RAW and Align Concverter.
|
Is concverter a real thing or a typo ? |
ccoVeille
reviewed
Sep 12, 2024
oviewer/oviewer.go
Outdated
Comment on lines
709
to
714
| if RawF { | ||
| root.General.Converter = convRaw | ||
| } | ||
| if AlignF { | ||
| root.General.Converter = convAlign | ||
| } |
There was a problem hiding this comment.
The logic is strange to read.
So AlignF "wins" vs RawF when present, right?
Maybe this?
Suggested change
| if RawF { | |
| root.General.Converter = convRaw | |
| } | |
| if AlignF { | |
| root.General.Converter = convAlign | |
| } | |
| if AlignF { | |
| root.General.Converter = convAlign | |
| } else if RawF { | |
| root.General.Converter = convRaw | |
| } |
oviewer/oviewer.go
Outdated
Comment on lines
376
to
380
| // RawF is specifies converter shortcut for raw. | ||
| var RawF bool | ||
|
|
||
| // AlignF is specifies converter shortcut for align. | ||
| var AlignF bool |
There was a problem hiding this comment.
Suggested change
| // RawF is specifies converter shortcut for raw. | |
| var RawF bool | |
| // AlignF is specifies converter shortcut for align. | |
| var AlignF bool | |
| // RawF specifies converter shortcut for raw. | |
| var RawF bool | |
| // AlignF specifies converter shortcut for align. | |
| var AlignF bool |
oviewer/oviewer.go
Outdated
Comment on lines
376
to
380
| // RawF is specifies converter shortcut for raw. | ||
| var RawF bool | ||
|
|
||
| // AlignF is specifies converter shortcut for align. | ||
| var AlignF bool |
There was a problem hiding this comment.
I don't think you need tgem to be exported
oviewer/oviewer.go
Outdated
Comment on lines
709
to
714
| if RawF { | ||
| root.General.Converter = convRaw | ||
| } | ||
| if AlignF { | ||
| root.General.Converter = convAlign | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you for your comment.
I moved to the main side and fixed it.
Typo. I will fix it. |
noborus
changed the title
Transferred shortcut handling for align and raw from oviewer/oviewer.go to main.go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a shortcut specified by RAW and Align converter.