Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help descriptions for better clarity #635

Merged
merged 3 commits into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,8 @@ func init() {
rootCmd.PersistentFlags().StringVarP(&nonMatchFilter, "non-match-filter", "", "", "filter non match search pattern")
rootCmd.PersistentFlags().BoolVarP(&oviewer.SkipExtract, "skip-extract", "", false, "skip extracting compressed files")

rootCmd.PersistentFlags().BoolVarP(&alignF, "align", "l", false, "align column")
rootCmd.PersistentFlags().BoolVarP(&rawF, "raw", "r", false, "raw output of escape sequences")
rootCmd.PersistentFlags().BoolVarP(&alignF, "align", "l", false, "align the output columns for better readability")
rootCmd.PersistentFlags().BoolVarP(&rawF, "raw", "r", false, "raw escape sequences without processing")

// Config.General
rootCmd.PersistentFlags().StringP("converter", "", "es", "converter [es|raw|align]")
Expand Down
2 changes: 1 addition & 1 deletion oviewer/content.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var SpaceContent = content{
style: tcell.StyleDefault,
}

// ShrinkContent is a content that represents a shrinked column.
// ShrinkContent is a content that represents a shrunk column.
var ShrinkContent = content{
mainc: Shrink,
combc: nil,
Expand Down
2 changes: 1 addition & 1 deletion oviewer/convert_es_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ func Test_parseCSI(t *testing.T) {
},
},
{
name: "test-atributesNone",
name: "test-attributesNone",
args: args{
params: "28",
},
Expand Down
4 changes: 2 additions & 2 deletions oviewer/input_search_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -278,14 +278,14 @@ func Test_stripBackSlash(t *testing.T) {
want string
}{
{
name: "nonEsacpe",
name: "nonEscape",
args: args{
str: "\test",
},
want: "\test",
},
{
name: "nonEsacpe2",
name: "nonEscape2",
args: args{
str: "!test",
},
Expand Down
6 changes: 3 additions & 3 deletions oviewer/keybind.go
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,8 @@ func (k KeyBind) String() string {
k.writeKeyBind(&b, actionTabWidth, "TAB width")
k.writeKeyBind(&b, actionMultiColor, "multi color highlight")
k.writeKeyBind(&b, actionJumpTarget, "jump target(`.n` or `n%` or `section` allowed)")
k.writeKeyBind(&b, actionAlignFormat, "align format")
k.writeKeyBind(&b, actionRawFormat, "raw format")
k.writeKeyBind(&b, actionAlignFormat, "align columns")
k.writeKeyBind(&b, actionRawFormat, "raw output")
k.writeKeyBind(&b, actionConvertType, "convert type selection")

writeHeader(&b, "Section")
Expand All @@ -365,7 +365,7 @@ func (k KeyBind) String() string {
k.writeKeyBind(&b, actionLastSection, "last section")
k.writeKeyBind(&b, actionFollowSection, "follow section mode toggle")
k.writeKeyBind(&b, actionSectionNum, "number of section header lines")
k.writeKeyBind(&b, actionHideOther, "toggle hide other section")
k.writeKeyBind(&b, actionHideOther, `hide "other" section toggle`)

writeHeader(&b, "Close and reload")
k.writeKeyBind(&b, actionCloseFile, "close file")
Expand Down
2 changes: 1 addition & 1 deletion oviewer/mouse_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func TestRoot_mouseEvent(t *testing.T) {
want: false,
},
{
name: "testShifWheelUp",
name: "testShiftWheelUp",
fields: fields{
ev: tcell.NewEventMouse(0, 0, tcell.WheelUp, tcell.ModShift),
},
Expand Down