-
Notifications
You must be signed in to change notification settings - Fork 48
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This commit fixes the stateless llama testing. Basically, with the setup + teardown approach of pytest unit testing, all the tests were sharing the same model from hugging face. We were running the streaming llama tests before the other tests. In these tests (run_torch_llm and export_transformer_model with streaming_llm=True), we do `enable_llama_pos_shift_attention(model)`, which changes the model we are using. So, this was giving us inaccurate results by the time it came to our base vmfb_comparison test. I created this issue to track and provide more info on the error we are now seeing with torch 2.3 in `test_ test_vmfb_comparison`: #601. Also, marked it as an expected failure for now. (changed runner because we are using previous machine to repro issue for tinygrad folks which can lead to instability and system hangs)
- Loading branch information
Showing
3 changed files
with
21 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters