Add a few decompositions for aten ops seen in huggingface models. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait this whole time we could have just decomposed lift_fresh_copy? 😭 |
dan-garvey
approved these changes
Oct 20, 2023
| @@ -43,6 +45,7 @@ | |||
| torch.ops.aten.nll_loss_backward, | |||
| torch.ops.aten._to_copy, | |||
| torch.ops.aten._log_softmax_backward_data, | |||
| torch.ops.aten.lift_fresh_copy.default, | |||
There was a problem hiding this comment.
Hey Ean,
I don't remember lift_fresh_copy decomposition registered from torch/_decomp.
(There's a lowering of it in inductor)
There's lift_fresh decomposition here: https://github.com/pytorch/pytorch/blob/main/torch/_decomp/decompositions.py#L1890
Currently, lift_fresh_copy is handled at here: https://github.com/nod-ai/SHARK-Turbine/blob/main/python/shark_turbine/dynamo/importer.py#L597-L602
by swapping the op to aten.clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.