[llama] transpose global state #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raikonenfnu
reviewed
Oct 24, 2023
dan-garvey
force-pushed
the
stateless_llllllamamaaaaaa
branch
from
6fb9798 to
9450405
Compare
KyleHerndon
approved these changes
Oct 30, 2023
| @@ -399,39 +388,54 @@ def run_vmfb_comparison(args): | |||
| example_input_id = initial_input.input_ids | |||
| device_inputs = [ireert.asdevicearray(config.device, example_input_id)] | |||
|
|
|||
| step0 = ModuleCompiled["get_seq_step"]() | |||
| print("step0 :"+str(step0)) | |||
| step0 = ModuleCompiled["get_seq_step"]() | |||
There was a problem hiding this comment.
This value is unused, remove.
Transposed the global state to allow continuous memory access while updating. Previously only the 0th idx of the 2nd dim was getting updated on initialization. Also update needs to be stored back to the global variable. Couple other minor bugfixes.
dan-garvey
force-pushed
the
stateless_llllllamamaaaaaa
branch
from
9450405 to
232a6f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transposed the global state to allow continuous memory access while updating. Previously only the 0th idx of the 2nd dim was getting updated on initialization. Also update needs to be stored back to the global variable. Couple other minor bugfixes.